Skip to content

Conversation

@DannyvdSluijs
Copy link
Collaborator

This pull request includes significant changes to the project configuration and codebase to improve code quality and enforce strict typing. The main changes involve removing the PHP CS Fixer configuration file and adding strict type declarations to various files.

Configuration changes:

  • Removed the PHP CS Fixer configuration file .php-cs-fixer.dist.php to streamline project setup and maintenance.

Code quality improvements:

  • Added declare(strict_types=1); to enforce strict typing in multiple files across the src/JsonSchema/Constraints directory, including BaseConstraint.php, CollectionConstraint.php, ConstConstraint.php, Constraint.php, ConstraintInterface.php, EnumConstraint.php, Factory.php, FormatConstraint.php, NumberConstraint.php, ObjectConstraint.php, SchemaConstraint.php, StringConstraint.php, TypeCheck/LooseTypeCheck.php, TypeCheck/StrictTypeCheck.php, TypeCheck/TypeCheckInterface.php, TypeConstraint.php, and UndefinedConstraint.php. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17]
  • Added declare(strict_types=1); to enforce strict typing in src/JsonSchema/ConstraintError.php and src/JsonSchema/Entity/JsonPointer.php. [1] [2]

@DannyvdSluijs DannyvdSluijs force-pushed the Add-declare-strict_types branch from 0f82775 to ce0b1d2 Compare November 21, 2024 21:07
@DannyvdSluijs DannyvdSluijs merged commit b5c8c9e into master Nov 21, 2024
19 checks passed
@DannyvdSluijs DannyvdSluijs deleted the Add-declare-strict_types branch November 21, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants