Skip to content

Tests on php 7.3 #575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 3, 2019
Merged

Tests on php 7.3 #575

merged 6 commits into from
Jun 3, 2019

Conversation

@SignpostMarv
Copy link
Contributor

@SignpostMarv SignpostMarv commented Jun 2, 2019

follows on from #563:

  • adjusts php-cs-fixer config to preserve existing behaviour, rather than applying new rules added in php-cs-fixer
  • splits the 7.0 run in two, so one can get feedback on php-cs-fixer before phpunit has finished running & so xdebug isn't loaded while php-cs-fixer runs.

erayd
erayd approved these changes Jun 3, 2019
View reviewed changes
Copy link
Contributor

@erayd erayd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @SignpostMarv 👍

@erayd erayd merged commit e0197a6 into jsonrainbow:master Jun 3, 2019
@erayd erayd mentioned this pull request Jun 3, 2019
Closed
@SignpostMarv SignpostMarv deleted the php-7.3 branch June 3, 2019 12:48
@SignpostMarv
Copy link
Contributor Author

SignpostMarv commented Jun 3, 2019

you're welcome :)

erayd pushed a commit to erayd/json-schema that referenced this pull request Sep 25, 2019
@SignpostMarv @erayd
Tests on php 7.3 (jsonrainbow#575)
27cc889 
* Tests on php 7.3
* bumping php-cs-fixer version as per comment from @erayd on jsonrainbow#563
* turning yoda style off to preserve previous behaviour
* some EOL versions of php require an older version of php-cs-fixer
* attempting to normalise behaviour with php-cs-fixer 2.2
* attempt separate run of php 7.0 to avoid having xdebug loaded when running php-cs-fixer
@erayd erayd mentioned this pull request Sep 25, 2019
Merged
erayd added a commit that referenced this pull request Sep 25, 2019
@erayd
Merge pull request #591 from erayd/backport-529
44c6787 
## Backported PRs
 * #559 ArraysTest for array items with enum validation
 * #567 Don't run checks which assume a defined instance against undefined
 * #575 Tests on PHP 7.3
 * #587 Fixed PHPDoc of Validator::validate() method
 * #583 Fix travis PHP 5.4 and 5.5 config

## Additional PRs (5.x.x only)
These PRs are only applicable to the 5.x.x branch, and have been merged individually.
 * #589 Update validate-json to use spl_autoload_register

## Skipped PRs
 * #464 marc-mabe/php-enum versions (dependency not present in 5.x.x)
@erayd erayd mentioned this pull request Nov 12, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erayd erayd erayd approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SignpostMarv @erayd @samnela