Fix warning on file_get_contents #153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 28, 2015
Closed
|
I'm looking forward to having this request pulled. |
|
+1 |
alecsammon
force-pushed
the
missingFileWarning
branch
from
8471636 to
15ce6bf
Compare
|
Tests added - let me know if you're happy with the format. |
bighappyface
added a commit
that referenced
this pull request
Jun 14, 2015
Fix warning on file_get_contents
|
Awesome - thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry - no test on this. Little bit tricky to write.
If file_get_contents fails then it reports a warning as well as returning false. The code then checks for false and throws an exception.
This pull request set's a custom error handler (and resets it) that suppresses the warning.
This should be safe to merge with #115.