Remove warning if file doesn't exist and send correct exception #138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, sorry hadn't really thought this pull request through! The problem I was trying to solve was the php warning if the file doesn't exist, however if fetching from a url then my solution is always going to fail. Therefor I don't think it's going to play nice with #115. Although I don't really like it as a solution, the easiest way I can see of getting this to work is to use the @ supressor - see http://stackoverflow.com/a/6463291 |
|
I think the best next step would be to create a test for this retriever so we can try out different URI scenarios 😉 |
|
Closed this pull request for now. Will reopen with tests later |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.