Fragment caching #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Nov 21, 2016
spec/renderer_spec.rb
Outdated
| @id.to_s | ||
| end | ||
|
|
||
| def jsonapi_cache_key(options = {}) |
There was a problem hiding this comment.
Unused method argument - options. If it's necessary, use _ or _options as an argument name to indicate that it won't be used. You can also write as jsonapi_cache_key(*) if you want the method to accept any arguments but don't care about them.
houndci-bot
reviewed
Nov 21, 2016
spec/renderer_spec.rb
Outdated
| @id.to_s | ||
| end | ||
|
|
||
| def jsonapi_cache_key(options = {}) |
There was a problem hiding this comment.
Unused method argument - options. If it's necessary, use _ or _options as an argument name to indicate that it won't be used. You can also write as jsonapi_cache_key(*) if you want the method to accept any arguments but don't care about them.
houndci-bot
reviewed
Nov 21, 2016
| @include = include | ||
| @fields = fields | ||
|
|
||
|
|
houndci-bot
reviewed
Nov 21, 2016
|
|
||
| def fetch_multi(keys, &block) | ||
| keys.each_with_object({}) do |k, h| | ||
| @cache[k] = block.call(k) unless @cache.key?(k) |
houndci-bot
reviewed
Nov 21, 2016
| @@ -1,19 +1,33 @@ | |||
| require 'set' | |||
|
|
|||
| class Cache | |||
There was a problem hiding this comment.
Missing top-level class documentation comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs benchmark.
Closes #9