Skip to content

Fix renderer #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fix renderer #9

wants to merge 2 commits into from

Conversation

@jnylen
Copy link

@jnylen jnylen commented Sep 3, 2017

Fixes #8

houndci-bot
houndci-bot reviewed Sep 3, 2017
View reviewed changes
lib/jsonapi/hanami/rendering.rb
self.format = :jsonapi if @format.nil?
return unless @_jsonapi.key?(:data)
self.body = JSONAPI::Serializable::Renderer.render(@_jsonapi[:data],
self.body = JSONAPI::Serializable::SuccessRenderer.new.render(@_jsonapi[:data],
Copy link

@houndci-bot houndci-bot Sep 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line is too long. [87/80]

@beauby
Copy link
Member

beauby commented Sep 12, 2017

Thanks for this! The actualy error is weird though, as jsonapi-serializable v0.1.1 does not have a SuccessRenderer (see here).

@beauby
Copy link
Member

beauby commented Sep 12, 2017

Right, but jsonapi-rb had loose dep pinning in 0.1.2, hence the current behavior.

@jnylen
Copy link
Author

jnylen commented Sep 13, 2017

Closed due to #12.

@jnylen jnylen closed this Sep 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@houndci-bot houndci-bot houndci-bot left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jnylen @beauby @houndci-bot