Bootstrap tests for draft 2020-12 #455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregsdennis
reviewed
Feb 24, 2021
Includes changes for `$recursiveAnchor` (removed), `$recursiveRef` (removed), `$dynamicAnchor`, `$dynamicRef`, `$prefixItems`, `items`, and `addtionalItems` (removed).
jdesrosiers
force-pushed
the
bootstrap-202012
branch
from
5911cbd to
e002409
Compare
gregsdennis
approved these changes
Feb 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I copied the tests from 2019-09 and made changes for the new and removed keywords. I haven't added or changed anything that wasn't necessary to get it working in 2020-12. That means it's not a complete suite for 2020-12, however I think the only thing that is lacking is
$dynamicAnchor/$dynamicRef. Only the functionality that overlap with$recursiveAnchor/$recursiveRefis covered. That can be added in a separate PR.I've verified these tests with my Hyperjump JSV implementation.
I put the copy of 2019-09 tests in a separate commit to make it easier to review. If you view only the commit(s) that come after that one, it should be easier to see what changed rather than a wall of green.