Rewrite of LinkBuilder to use ASP.NET Core routing to render links #987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bart-degreed
force-pushed
the
routing-links
branch
3 times, most recently
from
44f3461 to
830ba5d
Compare
Codecov Report
@@ Coverage Diff @@
## master #987 +/- ##
=======================================
Coverage 92.00% 92.01%
=======================================
Files 283 283
Lines 7658 7661 +3
=======================================
+ Hits 7046 7049 +3
Misses 612 612
Continue to review full report at Codecov.
|
bart-degreed
force-pushed
the
routing-links
branch
4 times, most recently
from
49f25fb to
a85606f
Compare
…he limitation that custom routes must end in the public resource name no longer applies.
- Fixed: Resource-level Self links in atomic:operations responses are now hidden when no controller exists for the resource type.
- Fixed: For determining which links to render, settings from primary resource were used on secondary endpoints. For example, if you configure Customer to show all links, but Orders no show none, then /customer/1/orders would show all links.
- Optimization: Compound `page[size]` parameter value (example: `10,articles:5`) is calculated once, instead of again for each pagination link.
- Deprecated: `IJsonApiRequest.BasePath`. This information is no longer needed, but we still set it for back-compat.
- Added support for non-standard route parameters in links, for example: `[DisableRoutingConvention, Route("{shopName}/products")]`
bart-degreed
force-pushed
the
routing-links
branch
from
a85606f to
3c05438
Compare
Contributor
Author
|
@alastairtree can you give this a try? |
maurei
approved these changes
May 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The limitation that custom routes must end in the public resource name no longer applies.
page[size]parameter value (example:10,articles:5) is calculated once, instead of again for each pagination link.IJsonApiRequest.BasePath. This information is no longer needed, but we still set it for back-compat.[DisableRoutingConvention, Route("{shopName}/products")]Fixes #956.
QUALITY CHECKLIST