Coding guidelines tweaks#965

Merged

bart-degreed merged 32 commits intomasterfrom

coding-guidelines-tweaks

Mar 11, 2021

Commits on Mar 8, 2021

Auto-formatted codebase using Resharper
Bart Koelman
committed
Replaced "var _" with discards
Bart Koelman
committed
Test: fail the build with an inspectcode warning
Bart Koelman
committed
Test: fail the build with formatting violations
Bart Koelman
committed
Revert "Test: fail the build with formatting violations"
Bart Koelman
committed
Revert "Test: fail the build with an inspectcode warning"
Bart Koelman
committed
Empty commit
Bart Koelman
committed
Use extension method for null/empty checks and assertions
Bart Koelman
committed
Removed unused code
Bart Koelman
committed
Formatting: trim trailing whitespace
Bart Koelman
committed
Boost various hints and suggestions to warning level during cibuild, to not bother devs too much while writing and debugging code.
Bart Koelman
committed
Fixed remaining warnings
Bart Koelman
committed
AV1250: Iterator method returns result of defered execution
Bart Koelman
committed
AV1706: Don't use single-letter variables
Bart Koelman
committed
AV1562: Do not use ref/out parameters
Bart Koelman
committed
Split up Act and Assert steps in tests
Bart Koelman
committed
AV1561: Do not return tuples with more than 2 parameters
Bart Koelman
committed
Minor cleanup
Bart Koelman
committed
AV1008: Class should not be static
Bart Koelman
committed
AV1010: Member hides inherited member
Bart Koelman
committed
AV1115: Member contains the word 'and', which suggests doing multiple things
Bart Koelman
committed
AV1210: Do not catch-all
Bart Koelman
committed
AV1708: Do not use 'Helper' or 'Shared' in type names
Bart Koelman
committed
Added CSharpGuidelinesAnalyzer with settings
Bart Koelman
committed

Commits on Mar 10, 2021

AV1130: Use collection interface as return type
Bart Koelman
committed
Simplified test code for hooks
Bart Koelman
committed
Automated code cleanup
Bart Koelman
committed
Refactored TypeHelper
Bart Koelman
committed
Set AV1555 to Warning level
Bart Koelman
committed

Commits on Mar 11, 2021

Renamed ITraversalHelper to INodeNavigator
Bart Koelman
committed
Renamed IHookExecutorHelper to IHookContainerProvider
Bart Koelman
committed
Fixed cibuild
Bart Koelman
committed