Fixed cibuild: poll for started webserver instead of fixed sleep #928
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bart-degreed
force-pushed
the
analyze-cibuild-errors
branch
2 times, most recently
from
7b326a5 to
50df545
Compare
bart-degreed
changed the title
… fixed sleep of 10 seconds after starting the webserver, which turned out to be insufficient. Switched to polling with 1 second interval for webserver to become online. Also changed to run this during PR build (without push), so we'll know in advance if docs generation breaks. Fixed invalid port number on mac/linux builds.
bart-degreed
force-pushed
the
analyze-cibuild-errors
branch
from
50df545 to
0074423
Compare
bart-degreed
changed the title
maurei
approved these changes
Jan 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cibuild was failing on documentation example generation. We had a fixed sleep of 10 seconds after starting the webserver, which turned out to be insufficient.
Switched to polling with 1 second interval for webserver to become online.
Also changed to run this during PR build (without push), so we'll know in advance if docs generation breaks.
Fixed invalid port number on mac/linux builds.