Best effort paging #840
Merged
Best effort paging #840
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 25, 2020 10:12
…f resources is unknown). This strategy is also applied on all secondary resources, as it is quite complex to determine total resource count. Fixed: exception on pass-through query string parameter in secondary request Optimization: skip query execution for primary resource if total count is zero Fixed: self link was calculated twice (in different ways) when paging active Fixed: nested page size was lost when rendering paging links Fixed: invalid paging links on secondary endpoints Fixed: cases where self link was different from the actual URL being requested (we now leave page number/size in, even when they match the default)
maurei
approved these changes
Sep 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #791.
Adds support for best-effort paging links (in case the total number of resources is unknown). This strategy is also applied on all secondary resources, as it is quite complex to determine total resource count.