Skip to content

Fix: crash when deserializing post with relationship to abstract base class #833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 46 commits into from
Oct 5, 2020
Merged

Fix: crash when deserializing post with relationship to abstract base class #833

merged 46 commits into from
Oct 5, 2020

Conversation

@maurei
Copy link
Member

@maurei maurei commented Sep 18, 2020 •
edited
Loading

Fixes #696

Introduces support for inheritance in resource models

@maurei maurei mentioned this pull request Sep 18, 2020
Closed
@maurei maurei changed the title Fix/696 Fix: crash when deserializing post with relationship to abstract base class Sep 18, 2020
@maurei maurei requested a review from bart-degreed September 18, 2020 15:44
@maurei maurei marked this pull request as ready for review September 18, 2020 15:44
bart-degreed
bart-degreed suggested changes Sep 21, 2020
View reviewed changes
@bart-degreed
Copy link
Contributor

bart-degreed commented Sep 21, 2020 •
edited
Loading

I would have expected changes in ResponseDeserializer.ParseIncludedRelationship too, it was marked as a place that needs to be updated in #828.

@maurei maurei mentioned this pull request Sep 28, 2020
Closed
@maurei maurei requested a review from bart-degreed September 28, 2020 12:46
@maurei
Copy link
Member Author

maurei commented Sep 28, 2020

I would have expected changes in ResponseDeserializer.ParseIncludedRelationship too, it was marked as a place that needs to be updated in #828.

Thanks for the heads up. Has been addressed now too.

bart-degreed
bart-degreed suggested changes Sep 29, 2020
View reviewed changes
Copy link
Contributor

@bart-degreed bart-degreed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will look at tests later.

bart-degreed
bart-degreed suggested changes Oct 1, 2020
View reviewed changes
@maurei maurei requested a review from bart-degreed October 2, 2020 14:56
bart-degreed
bart-degreed suggested changes Oct 2, 2020
View reviewed changes
@bart-degreed bart-degreed merged commit 65f9b49 into master Oct 5, 2020
@bart-degreed bart-degreed deleted the fix/696 branch October 5, 2020 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@RichardsonWTR RichardsonWTR RichardsonWTR left review comments

@bart-degreed bart-degreed bart-degreed approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

How to deserialize a class with a relationship that is a derived class?

4 participants

@maurei @bart-degreed @RichardsonWTR