Generic resource definitions #832
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 16, 2020 16:55
Made resource definitions a first-class pluggable extensibility point, similar to resource services and repositories. So developers now can derive from JsonApiResourceDefinition, implement IResourceDefinition, or insert base classes in the type hierarchy to share common logic. Such a base class can then be registered as an open generic, so that all resources will use that (unless the container finds a non-generic class, which is a better match) instead of the built-in JsonApiResourceDefinition. To accomplish this, I had to split up ResourceDefinition into two: - JsonApiResourceDefinition is highly pluggable like described above - ResourceHooksDefinition contains just the hook callbacks This way, the recursive resolve logic for resource hooks remains as-is. Since it did not use IResourceDefinitionProvider, that type has been replaced with IResourceDefinitionAccessor, which invokes the requested callbacks directly on the found class. What used to be IResourceDefinition (an intermediate type to invoke callbacks on) no longer exists.
Replaced IHasMeta with IResourceDefinition method
maurei
suggested changes
Sep 17, 2020
Member
maurei
left a comment
maurei
left a comment
There was a problem hiding this comment.
Partial review, will continue later today
maurei
approved these changes
Sep 17, 2020
Closed
maurei
suggested changes
Sep 18, 2020
maurei
approved these changes
Sep 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #806.
Made resource definitions a first-class pluggable extensibility point, similar to resource services and repositories. So developers now can derive from
JsonApiResourceDefinition, implementIResourceDefinition, or insert base classes in the type hierarchy to share common logic. Such a base class can then be registered as an open generic, so that all resources will use that (unless the container finds a non-generic class, which is a better match) instead of the built-inJsonApiResourceDefinition.To accomplish this, I had to split up
ResourceDefinitioninto two:JsonApiResourceDefinitionis highly pluggable like described aboveResourceHooksDefinitioncontains just the hook callbacksThis way, the recursive resolve logic for resource hooks remains as-is. Since it did not use
IResourceDefinitionProvider, that type has been replaced withIResourceDefinitionAccessor, which invokes the requested callbacks directly on the found class. What used to beIResourceDefinition(an internal type to invoke callbacks on) no longer exists.Additionally replaced
IHasMetawith a method onIResourceDefinitionand only scan for hook definitions when they are enabled. I intend to update documentation onIHasMeta(which was already wrong) later, as part of #737 (which may change these again).