Newtonsoft serializer settings #720
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
April 9, 2020 11:40
…ntrol naming convention
…ulls' and 'defaults'. Making them a single word allows us to not take the casing convention into account. Note this inverts the meaning of true/false in the query string value.
…-copied breaks with concurrent requests
… tests to cover all cases. Bugfix where default setting was never used, because the expression default(object) equals null, instead of the default value of the runtime type.
maurei
reviewed
Apr 13, 2020
src/JsonApiDotNetCore/Graph/ResourceNameFormatters/IResourceNameFormatter.cs
Show resolved
Hide resolved
maurei
approved these changes
Apr 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup and fixes for setting custom serializer behavior. The casing convention is now set there too.
Renamed omitNull/omitDefault query string parameters to nulls/defaults to prevent casing convention issues (note the parameter value is inverted now) and extended existing partial tests for them.
Fixes #687.
Fixes #718.
Fixes #697.