Skip to content

Removed leftover mappedby property #679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 12, 2020
Merged

Removed leftover mappedby property #679

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions src/JsonApiDotNetCore/Models/Annotation/HasManyThroughAttribute.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,15 +36,14 @@ public class HasManyThroughAttribute : HasManyAttribute
/// <param name="internalThroughName">The name of the navigation property that will be used to get the HasMany relationship</param>
/// <param name="relationshipLinks">Which links are available. Defaults to <see cref="Link.All"/></param>
/// <param name="canInclude">Whether or not this relationship can be included using the <c>?include=public-name</c> query string</param>
/// <param name="mappedBy">The name of the entity mapped property, defaults to null</param>
///
/// <example>
/// <code>
/// [HasManyThrough(nameof(ArticleTags), documentLinks: Link.All, canInclude: true)]
/// </code>
/// </example>
public HasManyThroughAttribute(string internalThroughName, Link relationshipLinks = Link.All, bool canInclude = true, string mappedBy = null)
: base(null, relationshipLinks, canInclude, mappedBy)
public HasManyThroughAttribute(string internalThroughName, Link relationshipLinks = Link.All, bool canInclude = true)
: base(null, relationshipLinks, canInclude)
{
InternalThroughName = internalThroughName;
}
Expand All @@ -57,15 +56,14 @@ public HasManyThroughAttribute(string internalThroughName, Link relationshipLink
/// <param name="internalThroughName">The name of the navigation property that will be used to get the HasMany relationship</param>
/// <param name="documentLinks">Which links are available. Defaults to <see cref="Link.All"/></param>
/// <param name="canInclude">Whether or not this relationship can be included using the <c>?include=public-name</c> query string</param>
/// <param name="mappedBy">The name of the entity mapped property, defaults to null</param>
///
/// <example>
/// <code>
/// [HasManyThrough("tags", nameof(ArticleTags), documentLinks: Link.All, canInclude: true)]
/// </code>
/// </example>
public HasManyThroughAttribute(string publicName, string internalThroughName, Link documentLinks = Link.All, bool canInclude = true, string mappedBy = null)
: base(publicName, documentLinks, canInclude, mappedBy)
public HasManyThroughAttribute(string publicName, string internalThroughName, Link documentLinks = Link.All, bool canInclude = true)
: base(publicName, documentLinks, canInclude)
{
InternalThroughName = internalThroughName;
}
Expand Down