Improving testability and intuitivity of hooks #529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elied on these methods
…oxy when RelationshipAttribute suffices
maurei
changed the title
wisepotato
suggested changes
Jun 21, 2019
src/Examples/JsonApiDotNetCoreExample/Controllers/TodoCollectionsController.cs
Show resolved
Hide resolved
wisepotato
approved these changes
Jun 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We found that when implementing resource hooks in our application, it wasn't very easy to unit test them. This was because 1) the resource helpers
AffectedRelationships,AffectedResources, andAffectedResourceDiffwere hard/impossible to mock/instantiate for unit testing, and because 2) these types don't give an intuitive feeling of the data structure they represent.This PR fixes this by introducing following changes
RelationshipProxywhere the use ofRelationshipAttributesuffices; this should make it easier to instantiateAffectedRelationships.AffectedRelationships,AffectedResourcesandAffectedResourceDiffhave been renamed toRelationshipsDictionary,EntityHashSetandEntityDiffsto make clear that (for the first two) you're actually just dealing with a dictionary and a hashset.