Skip to content

fix: fixed isimmutable not working #508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 6, 2019
Merged

fix: fixed isimmutable not working #508

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
943a7e3
fix: fixced isimmutable not working
May 16, 2019
4fb17fe
Update AttrAttribute.cs
wisepotato May 16, 2019
2af4a26
feat: updated tests for updating data with only get attribute set
May 17, 2019
d004167
fix: make tests work
May 17, 2019
ff50de8
Merge branch 'master' into fix/make-isimmutable-work
maurei Jun 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/JsonApiDotNetCore/Serialization/JsonApiDeSerializer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,11 +146,11 @@ private object SetEntityAttributes(
{
if (attributeValues.TryGetValue(attr.PublicAttributeName, out object newValue))
{
if (attr.IsImmutable)
continue;
var convertedValue = ConvertAttrValue(newValue, attr.PropertyInfo.PropertyType);
attr.SetValue(entity, convertedValue);

if (attr.IsImmutable == false)
_jsonApiContext.AttributesToUpdate[attr] = convertedValue;
_jsonApiContext.AttributesToUpdate[attr] = convertedValue;
}
}

Expand Down