Skip to content

Conversation

@bkoelman
Copy link
Member

Fixes a bug where an unneeded SQL query was executed when updating a one-to-one relationship. This was silently ignored on earlier versions of Entity Framework Core, but fails in the preview version of v8. The fix is to only execute the query when needed.

Details at: dotnet/efcore#31271.

QUALITY CHECKLIST

  • Changes implemented in code
  • Complies with our contributing guidelines
  • N/A: Adapted tests
  • N/A: Documentation updated

@codecov
Copy link

codecov bot commented Jul 16, 2023

Codecov Report

Merging #1289 (58b8f9f) into master (c0eb108) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 58b8f9f differs from pull request most recent head 336b725. Consider uploading reports for the commit 336b725 to get more accurate results

@@           Coverage Diff           @@
##           master    #1289   +/-   ##
=======================================
  Coverage   92.97%   92.97%           
=======================================
  Files         255      255           
  Lines        8254     8259    +5     
=======================================
+ Hits         7674     7679    +5     
  Misses        580      580           
Impacted Files Coverage Δ
...ApiDotNetCore.SourceGenerators/SourceCodeWriter.cs 97.61% <100.00%> (ø)
...Core/Repositories/EntityFrameworkCoreRepository.cs 96.11% <100.00%> (+0.06%) ⬆️

@bkoelman bkoelman requested a review from maurei July 16, 2023 12:32
@bkoelman bkoelman marked this pull request as ready for review July 16, 2023 12:32
@bkoelman bkoelman merged commit fe64052 into master Jul 23, 2023
@bkoelman bkoelman deleted the fix-efcore8 branch July 23, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants