Skip to content

Conversation

@bart-degreed
Copy link
Contributor

As it turns out, using blobs already works nicely using base64 encoding. This PR just adds tests for that.

Closes #1108.

QUALITY CHECKLIST

  • Changes implemented in code
  • Complies with our contributing guidelines
  • Adapted tests
  • N/A: Documentation updated
  • N/A: Created issue to update Templates: {ISSUE_NUMBER}

@bart-degreed bart-degreed requested a review from maurei December 8, 2021 12:23
@codecov
Copy link

codecov bot commented Dec 8, 2021

Codecov Report

Merging #1125 (4dd636e) into master (9c9a4f2) will increase coverage by 0.06%.
The diff coverage is 82.98%.

❗ Current head 4dd636e differs from pull request most recent head 5e7bd9b. Consider uploading reports for the commit 5e7bd9b to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1125      +/-   ##
==========================================
+ Coverage   89.41%   89.48%   +0.06%     
==========================================
  Files         245      241       -4     
  Lines        7294     7198      -96     
==========================================
- Hits         6522     6441      -81     
+ Misses        772      757      -15     
Impacted Files Coverage Δ
...NetCoreExample/Controllers/NonJsonApiController.cs 0.00% <0.00%> (ø)
...NetCoreExample/Controllers/OperationsController.cs 0.00% <0.00%> (ø)
...ples/JsonApiDotNetCoreExample/Data/AppDbContext.cs 0.00% <0.00%> (ø)
...otNetCoreExample/Definitions/TodoItemDefinition.cs 0.00% <0.00%> (ø)
...Examples/JsonApiDotNetCoreExample/Models/Person.cs 0.00% <0.00%> (ø)
...rc/Examples/JsonApiDotNetCoreExample/Models/Tag.cs 0.00% <0.00%> (ø)
...amples/JsonApiDotNetCoreExample/Models/TodoItem.cs 0.00% <0.00%> (ø)
src/Examples/JsonApiDotNetCoreExample/Program.cs 0.00% <0.00%> (ø)
...Core/AtomicOperations/MissingTransactionFactory.cs 0.00% <0.00%> (ø)
...sonApiDotNetCore/Diagnostics/CascadingCodeTimer.cs 0.00% <0.00%> (ø)
... and 353 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19f6557...5e7bd9b. Read the comment docs.

@bart-degreed bart-degreed merged commit 050d5c3 into master Dec 8, 2021
@bart-degreed bart-degreed deleted the blobs branch December 8, 2021 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Support for BLOBs

3 participants