-
-
Notifications
You must be signed in to change notification settings - Fork 159
Closed
Labels
Description
DESCRIPTION
List of small refactorings and code improvements:
- The classes
JsonApiController<TResource>andJsonApiController<TResource, TId>should be made abstract (and their constructors protected) - Optimization in catch block of
JsonApiResourceService.CreateAsync: only check for existing resource if an ID was specified in the request body:if (!Equals(resourceFromRequest.Id, default(TId))) { ... } - Rename
JsonApiDotNetCoreExampleTests.IntegrationTests.ReadWrite.WriteFakers.WorkTagsand..._lazyWorkTagsFakerto singular, like the rest in there - Add missing properties to serialization models, such as
document.jsonapiandlinks.describedby - Change
IResourceGraphdependency inJsonApiRoutingConventiontoIResourceContextProvider - Remove the code path for
if (_serializer == null)inJsonApiWriter.WriteAsync, because its constructor asserts that_serializercan never be null - Class
TestServerExtensionshas no usages and can be removed - Rename
EntityFrameworkCoreRepository.IsRequiredToManyRelationshipBeingClearedtoIsToManyRelationshipBeingCleared - Rename
IQueryLayerComposer.ComposeForHasManyThroughtoComposeForHasManyand change first parameter toHasManyAttribute hasManyRelationship(also update doc-comment to reflect this) - Search/replace remaining usages of
Context.RemoveRange(withClearTableAsyncin tests - Rename
IControllerResourceMapping.GetAssociatedResourcetoGetResourceTypeForController - Remove
IRequestQueryStringAccessor.QueryString(no usages)
maurei