If data is not provided, extract it from the PKCS7 instance. #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
great, we can add a test later (mostly use our own suite for these). feel free to merge or I will later, thanks. |
|
Ok thanks for the clarification. |
|
@kares Milestones seem to have not been updated since 0.9.18, so I closed out 0.9.18-0.9.20 and added 21 and 22, but I don't know for certain which issues were in which releases. I think we should try to have every issue tagged with a release, as in JRuby. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #132.
@kares I'm not sure if there's an MRI test that would pass now because of this change, or if we should just add our own (and not sure where that would go).