Flag when validation has validated for the first time. #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The change here looks fine but I am a interested what it might facilitate in react-formal. Since errors can be completely controlled in react-formal (essentially bypassing the Validator) I would be concerned that this isn't going to actually solve your use case 100% |
|
You're right; I guess it's for convenience more than necessity. We could listen for onValidate on the Form and manage our own Or, we could write a wrapper component for Form that takes care of that bit of state. Hm, might try that and get back to ya. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added this as a precursor to some work upstream in react-formal. We need the extra bit of state that says a form schema has not ever been validated.