Dependency Update: Pillow #121
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your suggestion, but I believe Pillow should remain optional since it is only required for ImageField. However, we can improve the error message (see #131 ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, sqlalchemy-file relies on Pillow as an optional dependency in [project.optional-dependencies]. However, from my observations, when users install sqlalchemy-file via poetry, Pillow is not automatically installed, leading to potential DEP002 errors when using ImageValidator.
To improve user experience and avoid such issues, I suggest moving "Pillow >=9.4.0, <10.1.0" from [project.optional-dependencies] to [project.dependencies]. This will allow Pillow to be automatically installed along with sqlalchemy-file.