macOS and swift 5 support #28
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tform as supported after reading over some of the cocoapods issues on github.
…nt exist. Causes build to fail on OSX. The original project had no pngs, nor should it rely on them so this should be safe to remove.
…lly copy to get it to work.
… makes the think it was the source argument catching the plist when it shouldnt.
platform support Co-authored-by: Ben Summers <[email protected]>
podspec Co-authored-by: Paul Zabelin <[email protected]>
Added a deployment target for osx, to fix cocoapods not seeing the pltform as supported after reading over some of the cocoapods issues on github. Co-authored-by: Ben Summers <[email protected]>
Removed the s.resources directive, it was trying to copy pngs that dont exist. Causes build to fail on OSX. The original project had no pngs, nor should it rely on them so this should be safe to remove. Co-authored-by: Paul Zabelin <[email protected]>
Added deployment targets for tvos Co-authored-by: Ben Summers <[email protected]>
I think the resource copy should be for the plist file I had to manually copy to get it to work. Co-authored-by: Paul Zabelin <[email protected]>
Last assumption was incorrect, but more searching of cocoapods issues makes the think it was the source argument catching the plist when it shouldnt. Co-authored-by: Ben Summers <[email protected]>
Co-authored-by: Paul Zabelin <[email protected]>
Co-authored-by: Ben Summers <[email protected]>
Co-authored-by: Ben Summers <[email protected]>
Co-authored-by: Paul Zabelin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix deprecated warnings, update to Xcode recommended settings