Untitled #2
Merged
Untitled #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Excellent addition. I ran the tests everything seemed fine, so I went ahead and merged. I welcome any additional contributions / ideas / etc! |
Zectbumo
pushed a commit
to Zectbumo/jsonrpclib
that referenced
this pull request
Feb 23, 2014
- Allows to use the 'client("close")()' method to close the
transport layer of a ServerProxy, even on Python 2.6
=> Fixes joshmarshall#2
- Updated tests to _really_ close the transport layer
(and not just to retrieve the closing method)
Zectbumo
pushed a commit
to Zectbumo/jsonrpclib
that referenced
this pull request
Feb 23, 2014
Zectbumo
pushed a commit
to Zectbumo/jsonrpclib
that referenced
this pull request
Feb 23, 2014
Also added supported Python versions to setup.py
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added support for UNIX domain sockets to jsonrpclib, for both clients and servers. You can look at the test case I added to see how it works; the client recognizes a URL of the form "unix:/tmp/jsonrpclib.sock", and the server takes an address_family parameter that can be set to AF_UNIX.
UNIX sockets have improved performance and security properties; the latter is why I needed a JSON-RPC implementation over UNIX sockets.