Updated action.js to Handle Locked LeetCode Premium Problems and Improve Sync Reliability #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added error handling in the `getInfo` function to skip locked problems. When the function encounters a locked problem (HTTP 403 error), it logs a message and skips the problem instead of retrying or throwing an exception. - Updated the `getQuestionData` function to handle locked problems. If fetching the question data results in a locked problem error (HTTP 403), it logs the error and returns null to indicate that the problem should be skipped. Modified the `sync` function to skip submissions related to locked problems. It continues the sync process for other problems, ensuring that locked problems do not cause the entire sync process to fail.
…f the leetcode-sync GitHub Action
joshcai
reviewed
Jun 23, 2024
src/action.js
Outdated
| @@ -415,13 +425,22 @@ async function sync(inputs) { | |||
| leetcodeSession, | |||
| leetcodeCSRFToken, | |||
| ); | |||
| if (!submission) { | |||
There was a problem hiding this comment.
Could you also do "submission === null" here to be consistent with L440?
README.md
Outdated
| @@ -48,7 +48,7 @@ GitHub Action for automatically syncing LeetCode submissions to a GitHub reposit | |||
|
|
|||
| steps: | |||
| - name: Sync | |||
| uses: joshcai/leetcode-sync@v1.6 | |||
| uses: AlyHG/leetcode-sync@master | |||
There was a problem hiding this comment.
Could you revert this line? I'll create a new release after this is in, and bump the version number up.
README.md
Outdated
| @@ -111,3 +111,17 @@ Special thanks to the following people who helped beta test this GitHub Action a | |||
| - [uakfdotb](https://github.com/uakfdotb) | |||
| - [hexecute](https://github.com/hexecute) | |||
| - [JonathanZhu11](https://github.com/JonathanZhu11) | |||
|
|
|||
| ## Updated by [Aly Ghallab](https://github.com/AlyHG) to Handle Locked LeetCode Premium Problems and Improve Sync Reliability - June 19, 2024 | |||
There was a problem hiding this comment.
Would it be okay if I add this info in the release notes section when creating a new release? e.g. similar to https://github.com/joshcai/leetcode-sync/releases/tag/v1.6
…for merge - Changed condition to "submission === null" in src/action.js for syntax consistency. - Reverted "uses" line in README.md to point back to joshcai/[email protected]. - Removed self-crediting section from README.md. Agreed to include this information in the release notes instead.
|
Hey, I applied your feedback and made the changes requested. Let me know if there's anything else. |
|
Thanks! Looks good to me now - merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This pull request addresses an issue where users with previously unlocked LeetCode premium problems would experience failures during the sync process. The following changes have been made:
getInfofunction to skip locked problems. When the function encounters a locked problem (HTTP 403 error), it logs a message and skips the problem instead of retrying or throwing an exception.getQuestionDatafunction to handle errors when fetching question data for locked problems. If fetching the question data results in a locked problem error (HTTP 403), it logs the error and returns null to indicate that the problem should be skipped.syncfunction to continue syncing other problems even if some are locked, ensuring that locked problems do not cause the entire sync process to fail.These changes improve the sync process by handling scenarios where some LeetCode problems are locked, allowing the action to continue syncing all available, unlocked problems successfully.