Add overloading method loginByKubernetes() with custom authPath #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dttung2905 <[email protected]>
Collaborator
|
Hi @dttung2905 , Don't worry and thank you. Sadly, this part lacks of tests, so is more simple to break something. I merge it, so that it will be present in future releases |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @henryx,
This PR adds an overloading method for
loginByKubernetes()as this new method accepts a new argauthPath. I should have included this in the previous PR #27 , so sorry about that. 😞In my downstream code, I could use the new method
loginByJwt()directly but I just want to make the vault-java-driver code base consistent, to avoid confusion for other users 🙏