Users frontend gherkin and acceptance scenarios #51

pritalpatel · 2016-07-10T11:14:35Z

Pull Request for Issue #16 and rewrite of #44

Summary of Changes

Create an users_frontend.feature file.

yvesh · 2016-07-10T13:22:27Z

tests/_support/AcceptanceTester.php

-		$I->waitForElement(['id' => 'mod-login-username'], 60);
-		$I->waitForText('Log in', 60, ['xpath' => "//fieldset[@class='loginform']//button"]);
+		$I->waitForElement(['id' => 'mod-login-username'], TIMEOUT);
+		$I->waitForText('Log in', TIMEOUT, ['xpath' => "//fieldset[@class='loginform']//button"]);


Instead of an xpath you can also use the btn-primary class as identifier. This should be faster and here it is important, as this method will be executed often.

yvesh · 2016-07-10T13:32:38Z

@pritalpatel This PR has merge conflicts you need to resolve. Ping me if you need help with that :-)

nibra · 2016-07-10T15:20:06Z

tests/acceptance/users_frontend.feature

+    And I create a user with fields Name "patel", Username "patel", Password "patel" and Email "[email protected]"
+    When I press the "Register"
+    Then I see "Could not instantiate mail function." message
+    And user is created


This scenario should be

Scenario: Create user from frontend (index.php?option=com_users) Given that user registration is enabled And there is no user with Username "patel" or Email "[email protected]" When I click on the link "Create an account" And I create a user with fields Name "patel", Username "patel", Password "patel" and Email "[email protected]" And I press the "Register" Then I see "Could not instantiate mail function." message And user is created

I click on the link "Create an account" is not a pre-condition, it is already part of your action, so it belongs to the When part.

I see "Could not instantiate mail function." message surely is not the expected message under the given pre-conditions. If you really mean this, add And mail is not configured correctly to the Given section. Otherwise, mail is assumed to be working as expected, and the message should contain Your account has been created.

Thanks for your suggestions. I will update it.

nibra · 2016-07-10T16:33:06Z

tests/acceptance/users_frontend.feature

+  Scenario: check the created user in the backend
+    Given There is a user manager page in administrator
+    When I search the user with user name "patel"
+    Then I should see the user "prital"


There is always a user manager - in current Joomla, you can't uninstall it. So it should be

Given I am on the User Manager page

The reference to the backend is not necessarily needed, because the User Manager page is in the backend. But it would not be wrong to say it explicitely.

nibra · 2016-07-11T11:18:34Z

tests/acceptance/users_frontend.feature

    And I create a user with fields Name "patel", Username "patel", Password "patel" and Email "[email protected]"
-    When I press the "Register"
+    And I press the "Register"
    Then I see "Could not instantiate mail function." message


Still wondering about this expected outcome.

pritalpatel · 2016-07-14T14:19:10Z

Travis is failing in PHP 5.6 because of weird error. Can we restart this build?

yvesh · 2016-07-14T14:31:15Z

@pritalpatel Updated Travis to only run our system tests.

javigomez · 2016-07-25T10:44:43Z

I have added fixes at pull #56:

fix missing call to step object: 6a3ff8f
fix typo: 78bc08c
simplify table xpaths: a1fbb91

javigomez · 2016-07-25T10:48:52Z

tests/acceptance/users_frontend.feature

+    And I press on "Log in"
+    Then I should see the "Login denied! Your account has either been blocked or you have not activated it yet." warning
+
+  Scenario: Check if block and activation are working


I would rename it for "Unblocked user can login in frontend"

javigomez · 2016-07-25T10:53:38Z

Closing since this pull has a clean version at #56

…a-projects#51

* Fix issue_#57 Update frontend_user tests as per commented in PR #51 * [codestyle] Adding docblock and code style improvement in Robo and user frontend * Verify in backend that user is created * Fix scenario in user_frontend.feature to proper English

@andrepereiradasilva

* Codestyle * indent * order * oops * changes requested by @andrepereiradasilva * cs * changes requested by @wojsmol * Update mod_logged.xml (#43) * Update templateDetails.xml (#45) i need to fix my ide!! * Update mod_popular.xml (#44) * Update templateDetails.xml (#57) * Update mod_version.xml (#56) * Update mod_toolbar.xml (#55) * Update mod_title.xml (#54) * Update mod_submenu.xml (#53) * Update mod_status.xml (#52) * Update mod_stats_admin.xml (#51) * Update mod_quickicon.xml (#50) * Update mod_menu.xml (#49) * Update mod_login.xml (#48) * Update mod_latest.xml (#47) * Update mod_feed.xml (#46)

pritalpatel mentioned this pull request Jul 10, 2016

Users frontend scenario- gherkin #44

Closed

yvesh reviewed Jul 10, 2016
View reviewed changes

nibra reviewed Jul 10, 2016
View reviewed changes

pritalpatel added 2 commits July 10, 2016 21:01

Using contants for timeouts

20109ea

Improvement in frontend feature

b7c316a

pritalpatel force-pushed the users-frontend-gherkin-new branch from 0674cc6 to b7c316a Compare July 10, 2016 15:32

nibra reviewed Jul 10, 2016
View reviewed changes

improve the scenario

d0378cc

nibra reviewed Jul 11, 2016
View reviewed changes

Implement user frontend scenarios

341a352

javigomez mentioned this pull request Jul 25, 2016

Users frontend gherkin new2 #56

Merged

javigomez reviewed Jul 25, 2016
View reviewed changes

javigomez mentioned this pull request Jul 25, 2016

Update frontend_user tests #57

Open

javigomez closed this Jul 25, 2016

pritalpatel changed the title ~~Users frontend gherkin new~~ Users frontend gherkin and acceptance scenarios Aug 4, 2016

pritalpatel deleted the users-frontend-gherkin-new branch August 4, 2016 14:15

pritalpatel added a commit to pritalpatel/gsoc16_browser-automated-tests that referenced this pull request Aug 6, 2016

Fix issue_#57 Update frontend_user tests as per commented in PR jooml…

41244a8

…a-projects#51

pritalpatel mentioned this pull request Aug 6, 2016

Fix issue #57 Update frontend_user tests #61

Merged

pritalpatel added a commit to pritalpatel/gsoc16_browser-automated-tests that referenced this pull request Aug 10, 2016

Fix issue_#57 Update frontend_user tests as per commented in PR jooml…

06b6313

…a-projects#51

pritalpatel added a commit to pritalpatel/gsoc16_browser-automated-tests that referenced this pull request Aug 17, 2016

Fix issue_#57 Update frontend_user tests as per commented in PR jooml…

cd2a8dd

…a-projects#51

pritalpatel added a commit to pritalpatel/gsoc16_browser-automated-tests that referenced this pull request Aug 21, 2016

Fix issue_#57 Update frontend_user tests as per commented in PR jooml…

bcf79d7

…a-projects#51

pritalpatel added a commit to pritalpatel/gsoc16_browser-automated-tests that referenced this pull request Aug 23, 2016

Fix issue_#57 Update frontend_user tests as per commented in PR jooml…

111fd8f

…a-projects#51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Users frontend gherkin and acceptance scenarios #51

Users frontend gherkin and acceptance scenarios #51

Uh oh!

pritalpatel commented Jul 10, 2016

Uh oh!

yvesh Jul 10, 2016 •

edited

Loading

Uh oh!

yvesh commented Jul 10, 2016

Uh oh!

nibra Jul 10, 2016

Uh oh!

pritalpatel Jul 10, 2016 •

edited

Loading

Uh oh!

nibra Jul 10, 2016

Uh oh!

nibra Jul 11, 2016

Uh oh!

pritalpatel commented Jul 14, 2016

Uh oh!

yvesh commented Jul 14, 2016

Uh oh!

javigomez commented Jul 25, 2016

Uh oh!

javigomez Jul 25, 2016

Uh oh!

javigomez commented Jul 25, 2016

Uh oh!

Uh oh!

Uh oh!

Users frontend gherkin and acceptance scenarios #51

Users frontend gherkin and acceptance scenarios #51

Uh oh!

Conversation

pritalpatel commented Jul 10, 2016

Summary of Changes

Uh oh!

yvesh Jul 10, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yvesh commented Jul 10, 2016

Uh oh!

nibra Jul 10, 2016

Choose a reason for hiding this comment

Uh oh!

pritalpatel Jul 10, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nibra Jul 10, 2016

Choose a reason for hiding this comment

Uh oh!

nibra Jul 11, 2016

Choose a reason for hiding this comment

Uh oh!

pritalpatel commented Jul 14, 2016

Uh oh!

yvesh commented Jul 14, 2016

Uh oh!

javigomez commented Jul 25, 2016

Uh oh!

javigomez Jul 25, 2016

Choose a reason for hiding this comment

Uh oh!

javigomez commented Jul 25, 2016

Uh oh!

Uh oh!

yvesh Jul 10, 2016 •

edited

Loading

pritalpatel Jul 10, 2016 •

edited

Loading