Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
59 commits
Select commit Hold shift + click to select a range
0a4862c
Merge commit '4fdb55f9832663275d195ff0c907b8b096c33aa1'
Aug 4, 2025
5d2d6a3
Merge commit '41d0a200c11132eaa1eb5a0c7659baec43d52316'
Aug 7, 2025
1e05fc1
Merge commit '62e86e22154e3b51a351ed4df0c38b5c867ded5d'
Aug 8, 2025
56048f8
Merge commit 'fffbe68733493aaae97f2d903dba633ba2903c6b'
Aug 8, 2025
0db540a
Merge commit 'dda30abda66b72db9a0eed709f983c26c052362f'
Aug 11, 2025
c154558
Merge commit '698c1cb106a63ae940d4304405b55fed0e672bca'
Aug 12, 2025
b6743c2
Merge commit '5f6723b80f820442b7d0e83e05b3041a0fb2138b'
Aug 12, 2025
08b125c
Merge commit '8adf2367132dbeab2ad278c8353951651d0be98b'
Aug 12, 2025
a236118
Merge commit '13576755f88b4d70f8d08cca3e6fc8dc4f75a9b8'
Aug 12, 2025
8d8ff9f
Merge commit '92f3c773efbd907af71978d657af5191c0126867'
Aug 12, 2025
b2bc561
Merge commit '3a79d909be03a856b84f7b54e9f9956f7d083707'
Aug 13, 2025
f4e92ec
Merge commit '2391204b53efbe7e7d7cb66beaad111afb585575'
Aug 13, 2025
30bdcdc
Update dependencies from https://dev.azure.com/dnceng/internal/_git/d…
dotnet-bot Aug 13, 2025
01d8598
Merged PR 52291: [internal/release/9.0.3xx] Update dependencies from …
Aug 13, 2025
e18a994
Update dependencies from https://dev.azure.com/dnceng/internal/_git/d…
dotnet-bot Aug 13, 2025
a72662c
Merged PR 52299: [internal/release/9.0.3xx] Update dependencies from …
Aug 13, 2025
9c402da
Update dependencies from https://dev.azure.com/dnceng/internal/_git/d…
dotnet-bot Aug 13, 2025
4d772fe
Merged PR 52307: [internal/release/9.0.3xx] Update dependencies from …
Aug 13, 2025
7f5cf3d
Merge commit '4045fb0069ed0d59d57f9a5ba8fa6e74bc606a60'
Aug 14, 2025
d7e10f8
Merge commit '2c9d41eb0ca7fc760bd73deeb7f693b042b2fc80'
Aug 14, 2025
52e0893
Merge commit '21d1e304dbb345eb36c187e63d9d9d4202ceabb2'
Aug 15, 2025
b07619a
Merge commit 'd3d16243e8cf59669dc741818deb75ce4fb2846f'
Aug 15, 2025
9614b68
Update dependencies from https://dev.azure.com/dnceng/internal/_git/d…
dotnet-bot Aug 15, 2025
0ce59cf
Merged PR 52361: [internal/release/9.0.3xx] Update dependencies from …
Aug 16, 2025
3186d55
Update dependencies from https://dev.azure.com/dnceng/internal/_git/d…
dotnet-bot Aug 16, 2025
678239e
Update dependencies from https://dev.azure.com/dnceng/internal/_git/d…
dotnet-bot Aug 16, 2025
a9aac9b
Update dependencies from https://dev.azure.com/dnceng/internal/_git/d…
dotnet-bot Aug 16, 2025
e6673b4
Merged PR 52377: [internal/release/9.0.3xx] Update dependencies from …
Aug 17, 2025
c30deae
Update dependencies from https://dev.azure.com/dnceng/internal/_git/d…
dotnet-bot Aug 17, 2025
cc81b77
Merge commit 'cf275d46ba436d8f61a33c3e236c30a9fd751bbd'
Aug 18, 2025
03499b9
Merge commit 'e11716391959c758252aeb7ec03efb2a9157ed71'
Aug 18, 2025
32aa4ba
Merge commit '04a554729fb3a1a761885ca1772870d523ddadd5'
Aug 18, 2025
cf570ab
Merged PR 52387: [internal/release/9.0.3xx] Update dependencies from …
Aug 18, 2025
ef945a6
Update dependencies from https://dev.azure.com/dnceng/internal/_git/d…
dotnet-bot Aug 20, 2025
636f25f
Merged PR 52495: [internal/release/9.0.3xx] Update dependencies from …
Aug 20, 2025
c488a9f
Update dependencies from https://dev.azure.com/dnceng/internal/_git/d…
dotnet-bot Aug 20, 2025
b2ce469
Update dependencies from https://dev.azure.com/dnceng/internal/_git/d…
dotnet-bot Aug 20, 2025
be3d92b
Merged PR 52511: [internal/release/9.0.3xx] Update dependencies from …
Aug 20, 2025
940254f
Update dependencies from https://dev.azure.com/dnceng/internal/_git/d…
dotnet-bot Aug 21, 2025
3fc74f3
Merged PR 52591: [internal/release/9.0.3xx] Update dependencies from …
Aug 21, 2025
f56b93a
Merge commit '3fc74f35299b08613acefa6fa7d70ccd72ff6139' into internal…
vseanreesermsft Sep 9, 2025
02a6d88
Upgrade scancode to 32.4.1
Winniexu01 Sep 12, 2025
b3b89b6
Upgrade scancode to 32.4.1 (#50777)
mthalman Sep 12, 2025
eebf2c2
Add static to fix IDE0062 (#50771)
marcpopMSFT Sep 12, 2025
b3e9785
Merge branch 'release/9.0.3xx' into internal-merge-9.0.3xx-2025-09-09…
marcpopMSFT Sep 12, 2025
49b8e2d
Update dependencies from https://github.com/dotnet/source-build-refer…
dotnet-maestro[bot] Sep 13, 2025
1c1a027
Update dependencies from https://github.com/dotnet/arcade build 20250…
dotnet-maestro[bot] Sep 13, 2025
61ef73b
Update dependencies from https://github.com/dotnet/arcade build 20250…
dotnet-maestro[bot] Sep 13, 2025
fc9103f
[release/9.0.3xx] Update dependencies from dotnet/arcade (#50804)
SimonZhao888 Sep 15, 2025
749d24c
[release/9.0.1xx] Update dependencies from dotnet/source-build-refere…
SimonZhao888 Sep 15, 2025
286ec9c
[release/9.0.1xx] Update dependencies from dotnet/arcade (#50803)
SimonZhao888 Sep 15, 2025
c5d7d85
Merge branch 'release/9.0.3xx' of https://github.com/dotnet/sdk into …
Sep 15, 2025
7be4fcf
[automated] Merge branch 'release/9.0.1xx' => 'release/9.0.3xx' (#50827)
SimonZhao888 Sep 15, 2025
0feebe4
Merge branch 'release/9.0.3xx' into internal-merge-9.0.3xx-2025-09-09…
marcpopMSFT Sep 15, 2025
2358fd9
[9.0.3xx] detect .NET 10 RID-specific tools and provide a more action…
baronfel Sep 15, 2025
67dfe65
Merging internal commits for release/9.0.3xx (#50711)
marcpopMSFT Sep 15, 2025
80089b8
Merge branch 'release/10.0.1xx' of https://github.com/dotnet/sdk into…
Sep 16, 2025
6b2817e
[automated] Merge branch 'release/9.0.3xx' => 'release/10.0.1xx' (#50…
SimonZhao888 Sep 16, 2025
0439a83
Publish/pack file-based apps in Release config by default (#50681)
jjonescz Sep 16, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions NuGet.config
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,6 @@
<!-- End: Package sources from dotnet-aspire -->
<!-- Begin: Package sources from dotnet-runtime -->
<add key="darc-int-dotnet-runtime-893c2eb" value="https://pkgs.dev.azure.com/dnceng/internal/_packaging/darc-int-dotnet-runtime-893c2ebb/nuget/v3/index.json" />
<add key="darc-int-dotnet-runtime-893c2eb-4" value="https://pkgs.dev.azure.com/dnceng/internal/_packaging/darc-int-dotnet-runtime-893c2ebb-4/nuget/v3/index.json" />
<add key="darc-int-dotnet-runtime-893c2eb-3" value="https://pkgs.dev.azure.com/dnceng/internal/_packaging/darc-int-dotnet-runtime-893c2ebb-3/nuget/v3/index.json" />
<add key="darc-int-dotnet-runtime-893c2eb-2" value="https://pkgs.dev.azure.com/dnceng/internal/_packaging/darc-int-dotnet-runtime-893c2ebb-2/nuget/v3/index.json" />
<add key="darc-int-dotnet-runtime-893c2eb-1" value="https://pkgs.dev.azure.com/dnceng/internal/_packaging/darc-int-dotnet-runtime-893c2ebb-1/nuget/v3/index.json" />
<!-- End: Package sources from dotnet-runtime -->
<!--End: Package sources managed by Dependency Flow automation. Do not edit the sources above.-->
<add key="dotnet6" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet6/nuget/v3/index.json" />
Expand Down Expand Up @@ -42,10 +38,6 @@
<clear />
<!--Begin: Package sources managed by Dependency Flow automation. Do not edit the sources below.-->
<!-- Begin: Package sources from dotnet-runtime -->
<add key="darc-int-dotnet-runtime-893c2eb-1" value="true" />
<add key="darc-int-dotnet-runtime-893c2eb-2" value="true" />
<add key="darc-int-dotnet-runtime-893c2eb-3" value="true" />
<add key="darc-int-dotnet-runtime-893c2eb-4" value="true" />
<add key="darc-int-dotnet-runtime-893c2eb" value="true" />
<!-- End: Package sources from dotnet-runtime -->
<!--End: Package sources managed by Dependency Flow automation. Do not edit the sources above.-->
Expand Down
7 changes: 7 additions & 0 deletions eng/common/core-templates/job/publish-build-assets.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@ parameters:

repositoryAlias: self

officialBuildId: ''

jobs:
- job: Asset_Registry_Publish

Expand All @@ -62,6 +64,11 @@ jobs:
value: false
# unconditional - needed for logs publishing (redactor tool version)
- template: /eng/common/core-templates/post-build/common-variables.yml
- name: OfficialBuildId
${{ if ne(parameters.officialBuildId, '') }}:
value: ${{ parameters.officialBuildId }}
${{ else }}:
value: $(Build.BuildNumber)

pool:
# We don't use the collection uri here because it might vary (.visualstudio.com vs. dev.azure.com)
Expand Down
2 changes: 2 additions & 0 deletions eng/common/core-templates/jobs/jobs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ parameters:
artifacts: {}
is1ESPipeline: ''
repositoryAlias: self
officialBuildId: ''

# Internal resources (telemetry, microbuild) can only be accessed from non-public projects,
# and some (Microbuild) should only be applied to non-PR cases for internal builds.
Expand Down Expand Up @@ -116,3 +117,4 @@ jobs:
artifactsPublishingAdditionalParameters: ${{ parameters.artifactsPublishingAdditionalParameters }}
signingValidationAdditionalParameters: ${{ parameters.signingValidationAdditionalParameters }}
repositoryAlias: ${{ parameters.repositoryAlias }}
officialBuildId: ${{ parameters.officialBuildId }}
5 changes: 4 additions & 1 deletion src/Cli/dotnet/Commands/CommandFactory.cs
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@ internal static CommandBase CreateVirtualOrPhysicalCommand(
Func<MSBuildArgs, string?, CommandBase> createPhysicalCommand,
IEnumerable<Option> optionsToUseWhenParsingMSBuildFlags,
ParseResult parseResult,
string? msbuildPath = null)
string? msbuildPath = null,
Func<MSBuildArgs, MSBuildArgs>? transformer = null)
{
var args = parseResult.GetValue(catchAllUserInputArgument) ?? [];
LoggerUtility.SeparateBinLogArguments(args, out var binLogArgs, out var nonBinLogArgs);
Expand All @@ -32,11 +33,13 @@ internal static CommandBase CreateVirtualOrPhysicalCommand(
CommonOptions.GetTargetResultOption,
CommonOptions.GetResultOutputFileOption,
]);
msbuildArgs = transformer?.Invoke(msbuildArgs) ?? msbuildArgs;
return configureVirtualCommand(msbuildArgs, Path.GetFullPath(arg));
}
else
{
var msbuildArgs = MSBuildArgs.AnalyzeMSBuildArguments([.. forwardedArgs, .. args], [.. optionsToUseWhenParsingMSBuildFlags]);
msbuildArgs = transformer?.Invoke(msbuildArgs) ?? msbuildArgs;
return createPhysicalCommand(msbuildArgs, msbuildPath);
}
}
Expand Down
29 changes: 15 additions & 14 deletions src/Cli/dotnet/Commands/Pack/PackCommand.cs
Original file line number Diff line number Diff line change
Expand Up @@ -49,19 +49,10 @@ public static CommandBase FromParseResult(ParseResult parseResult, string? msbui
NoRestore = noRestore,
NoCache = true,
},
(msbuildArgs, msbuildPath) =>
{
ReleasePropertyProjectLocator projectLocator = new(parseResult, MSBuildPropertyNames.PACK_RELEASE,
new ReleasePropertyProjectLocator.DependentCommandOptions(
nonBinLogArgs,
parseResult.HasOption(PackCommandParser.ConfigurationOption) ? parseResult.GetValue(PackCommandParser.ConfigurationOption) : null
)
);
return new PackCommand(
msbuildArgs.CloneWithAdditionalProperties(projectLocator.GetCustomDefaultConfigurationValueIfSpecified()),
noRestore,
msbuildPath);
},
(msbuildArgs, msbuildPath) => new PackCommand(
msbuildArgs,
noRestore,
msbuildPath),
optionsToUseWhenParsingMSBuildFlags:
[
CommonOptions.PropertiesOption,
Expand All @@ -70,7 +61,17 @@ public static CommandBase FromParseResult(ParseResult parseResult, string? msbui
PackCommandParser.VerbosityOption,
],
parseResult,
msbuildPath);
msbuildPath,
(msbuildArgs) =>
{
ReleasePropertyProjectLocator projectLocator = new(parseResult, MSBuildPropertyNames.PACK_RELEASE,
new ReleasePropertyProjectLocator.DependentCommandOptions(
nonBinLogArgs,
parseResult.HasOption(PackCommandParser.ConfigurationOption) ? parseResult.GetValue(PackCommandParser.ConfigurationOption) : null
)
);
return msbuildArgs.CloneWithAdditionalProperties(projectLocator.GetCustomDefaultConfigurationValueIfSpecified());
});
}

private static LogLevel MappingVerbosityToNugetLogLevel(VerbosityOptions? verbosity)
Expand Down
22 changes: 12 additions & 10 deletions src/Cli/dotnet/Commands/Publish/PublishCommand.cs
Original file line number Diff line number Diff line change
Expand Up @@ -52,23 +52,25 @@ public static CommandBase FromParseResult(ParseResult parseResult, string? msbui
NoRestore = noRestore,
NoCache = true,
},
(msbuildArgs, msbuildPath) => {
(msbuildArgs, msbuildPath) => new PublishCommand(
msbuildArgs: msbuildArgs,
noRestore: noRestore,
msbuildPath: msbuildPath
),
[CommonOptions.PropertiesOption, CommonOptions.RestorePropertiesOption, PublishCommandParser.TargetOption, PublishCommandParser.VerbosityOption],
parseResult,
msbuildPath,
(msbuildArgs) =>
{
var options = new ReleasePropertyProjectLocator.DependentCommandOptions(
nonBinLogArgs,
parseResult.HasOption(PublishCommandParser.ConfigurationOption) ? parseResult.GetValue(PublishCommandParser.ConfigurationOption) : null,
parseResult.HasOption(PublishCommandParser.FrameworkOption) ? parseResult.GetValue(PublishCommandParser.FrameworkOption) : null
);
var projectLocator = new ReleasePropertyProjectLocator(parseResult, MSBuildPropertyNames.PUBLISH_RELEASE, options);
var releaseModeProperties = projectLocator.GetCustomDefaultConfigurationValueIfSpecified();
return new PublishCommand(
msbuildArgs: msbuildArgs.CloneWithAdditionalProperties(releaseModeProperties),
noRestore: noRestore,
msbuildPath: msbuildPath
);
},
[CommonOptions.PropertiesOption, CommonOptions.RestorePropertiesOption, PublishCommandParser.TargetOption, PublishCommandParser.VerbosityOption],
parseResult,
msbuildPath
return msbuildArgs.CloneWithAdditionalProperties(releaseModeProperties);
}
);
}

Expand Down
9 changes: 8 additions & 1 deletion src/Cli/dotnet/ReleasePropertyProjectLocator.cs
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,9 @@
using System.Collections.ObjectModel;
using System.CommandLine;
using System.Diagnostics;
using Microsoft.Build.Evaluation;
using Microsoft.Build.Execution;
using Microsoft.DotNet.Cli.Commands.Run;
using Microsoft.DotNet.Cli.Utils;
using Microsoft.NET.Build.Tasks;
using Microsoft.VisualStudio.SolutionPersistence.Model;
Expand Down Expand Up @@ -108,7 +110,12 @@ DependentCommandOptions commandOptions
{
foreach (string arg in _slnOrProjectArgs.Append(Directory.GetCurrentDirectory()))
{
if (IsValidProjectFilePath(arg))
if (VirtualProjectBuildingCommand.IsValidEntryPointPath(arg))
{
return new VirtualProjectBuildingCommand(Path.GetFullPath(arg), MSBuildArgs.FromProperties(globalProps))
.CreateProjectInstance(ProjectCollection.GlobalProjectCollection);
}
else if (IsValidProjectFilePath(arg))
{
return TryGetProjectInstance(arg, globalProps);
}
Expand Down
16 changes: 15 additions & 1 deletion test/dotnet.Tests/CommandTests/Run/RunFileTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -1504,6 +1504,14 @@ public void Publish()
new DirectoryInfo(publishDir).Sub("Program")
.Should().Exist()
.And.NotHaveFilesMatching("*.deps.json", SearchOption.TopDirectoryOnly); // no deps.json file for AOT-published app

new RunExeCommand(Log, Path.Join(publishDir, "Program", $"Program{Constants.ExeSuffix}"))
.Execute()
.Should().Pass()
.And.HaveStdOut("""
Hello from Program
Release config
""");
}

[Fact]
Expand Down Expand Up @@ -1689,6 +1697,9 @@ public void Pack()
File.WriteAllText(programFile, """
#:property PackAsTool=true
Console.WriteLine($"Hello; EntryPointFilePath set? {AppContext.GetData("EntryPointFilePath") is string}");
#if !DEBUG
Console.WriteLine("Release config");
#endif
""");

// Run unpacked.
Expand Down Expand Up @@ -1719,7 +1730,10 @@ public void Pack()
.WithWorkingDirectory(testInstance.Path)
.Execute()
.Should().Pass()
.And.HaveStdOutContaining("Hello; EntryPointFilePath set? False");
.And.HaveStdOutContaining("""
Hello; EntryPointFilePath set? False
Release config
""");
}

[Fact]
Expand Down
Loading