-
Notifications
You must be signed in to change notification settings - Fork 2
Integrate plugin-rescript
#13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/jihchi/app-template-rescript-react/CXUfVGd7CwruPPnoz8Ua1zpwF911 |
package.json
Outdated
| "react-dom": "^17.0.2" | ||
| }, | ||
| "devDependencies": { | ||
| "@jihchi/plugin-rescript": "0.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome @jihchi
| "build:res": "rescript build", | ||
| "clean": "npm run clean:res", | ||
| "clean:res": "rescript clean", | ||
| "build": "snowpack build", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have an issue I founded, when run build command. index.bs.js not found

Reproduce
yarn clean; yarn buildbuild command not run rescript build.
@jihchi I think @jihci/plugin-rescript is missing async optimize(buildOptions, args){} in plugin.js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ri7nz , thanks for the comment!
Sorry, this PR and the plug-in are still working in progress, it is an experimental work and this might not be merged if things does not go well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jihchi , thanks for your response.
I know for this situation, I'm just want to help your work 🙌


@jihchi/plugin-rescriptand deprecate @snowpack/plugin-run-script3.0.xbecause of a regression inbuildstage, see [BUG] plugin-run-script not waiting for eleventy to finish during build FredKSchott/snowpack#3095