Skip to content

Conversation

@jihchi
Copy link
Owner

@jihchi jihchi commented Apr 18, 2021

@vercel
Copy link

vercel bot commented Apr 18, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/jihchi/app-template-rescript-react/CXUfVGd7CwruPPnoz8Ua1zpwF911
✅ Preview: https://app-template-rescript-react-git-integrateplugin-rescript-jihchi.vercel.app

package.json Outdated
"react-dom": "^17.0.2"
},
"devDependencies": {
"@jihchi/plugin-rescript": "0.0.0",
Copy link
Contributor

@r17x r17x Apr 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome @jihchi

"build:res": "rescript build",
"clean": "npm run clean:res",
"clean:res": "rescript clean",
"build": "snowpack build",
Copy link
Contributor

@r17x r17x Apr 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have an issue I founded, when run build command. index.bs.js not found
image

image

Reproduce

yarn clean; yarn build

image

build command not run rescript build.

@jihchi I think @jihci/plugin-rescript is missing async optimize(buildOptions, args){} in plugin.js

Copy link
Owner Author

@jihchi jihchi Apr 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ri7nz , thanks for the comment!

Sorry, this PR and the plug-in are still working in progress, it is an experimental work and this might not be merged if things does not go well.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jihchi , thanks for your response.

I know for this situation, I'm just want to help your work  🙌

@jihchi jihchi merged commit d364918 into main Apr 25, 2021
@jihchi jihchi deleted the integrate_plugin-rescript branch April 25, 2021 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants