Skip to content

Fix some accessibility issues. #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix some accessibility issues. #17

wants to merge 3 commits into from

Conversation

unused
Copy link

@unused unused commented Nov 26, 2016

  • Highlight focus for keyboard users.
  • Add some base landmarks (main, menu, search).
  • Label some links that are not described by their link text.
  • Add a skip to main content link.
  • Add a hint for developers to ease contribution.

@unused
Fix some accessibility issues.
375286e 
- Highlight focus for keyboard users.
- Add some base landmarks (main, menu, search).
- Label some links that are not described by their link text.
- Add a skip to main content link.
- Add a hint for developers to ease contribution.
@marcus-herrmann
Copy link

Great PR!
The main search input needs both a (screen reader visible) label and a submit button, in my opinion. Input type="search" doesn't suffice for assistive technology.

@unused
Copy link
Author

unused commented Nov 28, 2016

thx @marcus-herrmann - I'm not sure how to deal with this menu filter, I'll look it up and see if I can find a better solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@unused @marcus-herrmann