Docker based backend

[jfischoff]

It is seems possible to control postgres via docker and desirable for a few reasons:

• Better process and resource cleanup.
• Built in caching via image snapshots.
• You only need docker installed and not postgres on the path.

I think there might be a way to have several backends for making Plans. One could be the current non-docker plan executor and one could be the Docker based Plan executor.

There are downsides as well so I don't think it should be the default.

[jfischoff]

Some observations

1. No UNIX socket
2. I would still want to generate a random port
3. No need to generate a random data directory
4. Could I use mounts to point a Permanent data directory?

So this something that interprets a Config and makes a new Plan that is specialized for running docker.

[jfischoff]

Caching and snapshots use docker snapshots somehow.

[jfischoff]

docker commit

[jfischoff]

https://docs.docker.com/engine/reference/commandline/commit/

[jfischoff]

Some thoughts.

I don't know if it is faster to use docker. I have to create a container (~0.156) but I the commit command is not working as I would like because by default the postgres container is storing info in a volume which is not persisted AFAICT by commit.

[jfischoff]

Using -e PGDATA=/tmp/data works. However the time is still ~0.5s so this is still a slower method. Probably still worth doing though.

[GambolingPangolin]

I have some tests that use your wonderful package, but it is quite difficult to get them to work in GitHub Actions. The recommended practice is to use a containerized postgresql instance instead of setting up a cluster on the same host. This is not quite what you describe in this issue, since GitHub Actions deploys the container. However it would be great to be able to use this package for that CI mode!

[jfischoff]

I’ve never tried to use Github actions just travis ci. Yeah I’m not dure what changes would be necessary to work with that.

…

On Fri, Oct 30, 2020 at 12:42 PM Ian Shipman ***@***.***> wrote: I have some tests that use your wonderful package, but it is quite difficult to get them to work in GitHub Actions. The recommended practice is to use a containerized postgresql instance instead of setting up a cluster on the same host. This is not quite what you describe in this issue, since GitHub Actions deploys the container. However it would be great to be able to use this package for that CI mode! — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#199 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABJEO23EP2KPUC6X6CHIKDSNMJJZANCNFSM4JUWP7BA> .

[GambolingPangolin]

I just figured out how to make it work today. I'd be happy to add a section to the readme (or create a new doc) explaining how to do it if that seems to you like a positive contribution.

[GambolingPangolin]

The approach I used does not use containers. It just modifies the github actions environment so that tmp-postgres will run correctly.

[GambolingPangolin]

Oh. I just checked and all I had to do was follow your installation instructions, but I missed them when I first looked at your readme.

[jfischoff]

Yeah by all means make a PR

…

On Fri, Oct 30, 2020 at 3:27 PM Ian Shipman ***@***.***> wrote: The approach I used does not use containers. It just modifies the github actions environment so that tmp-postgres will run correctly. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#199 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABJEOYVTKXQQJDDYQZDLE3SNM4WZANCNFSM4JUWP7BA> .