delete($id) method masks parent delete() method

[lfolco]

I'm seeing an error in the logs about this method:

https://github.com/jetrails/magento-cloudflare/blob/master/src/app/code/community/JetRails/Cloudflare/Model/Adminhtml/Api/Firewall/AccessRules.php#L26

The delete($id) method has a different method signature than the one in \Mage_Core_Model_Abstract::delete().

[null93]

Hello, thanks for taking the time to open a ticket about this! Can you paste the actual error you are seeing from the log file? I am not sure if it is necessary to keep the same signature as the base class for this module's use case. That being said, I am willing to change it for compatibility sake since the solution is really harmless.

Solution should be as easy as renaming the method to something other than delete. Something like deleteEntry should do. Effected classes:

• src/app/code/community/JetRails/Cloudflare/Model/Adminhtml/Api/Firewall/AccessRules.php
• src/app/code/community/JetRails/Cloudflare/Model/Adminhtml/Api/Firewall/ZoneLockdown.php
• src/app/code/community/JetRails/Cloudflare/Model/Adminhtml/Api/Firewall/UserAgentBlocking.php
• src/app/code/community/JetRails/Cloudflare/Model/Adminhtml/Api/PageRules/PageRules.php

[lfolco]

It's showing up in the network tab for the cloudflare_api_firewall_accessRules/ call. I have developer mode enabled where it will stop on notice errors.

<pre>Warning: Declaration of JetRails_Cloudflare_Model_Adminhtml_Api_Firewall_AccessRules::delete($id) should be compatible with Mage_Core_Model_Abstract::delete()  in /home/xxx/xxx.com/app/code/community/JetRails/Cloudflare/Model/Adminhtml/Api/Firewall/AccessRules.php on line 13

#0 /home/xxx/xxx.com/app/code/community/JetRails/Cloudflare/Model/Adminhtml/Api/Firewall/AccessRules.php(13): mageCoreErrorHandler(2, 'Declaration of ...', '/home/xxx/xxx...', 13, Array)
#1 /home/xxx/xxx.com/lib/Varien/Autoload.php(93): include('/home/xxx/xxx...')
#2 [internal function]: Varien_Autoload->autoload('JetRails_Cloudf...')
#3 [internal function]: spl_autoload_call('JetRails_Cloudf...')
#4 /home/xxx/xxx.com/app/code/core/Mage/Core/Model/Config.php(1354): class_exists('JetRails_Cloudf...')
#5 /home/xxx/xxx.com/app/Mage.php(462): Mage_Core_Model_Config->getModelInstance('cloudflare/api_...', Array)
#6 /home/xxx/xxx.com/app/code/community/JetRails/Cloudflare/Controller/Getter.php(27): Mage::getModel('cloudflare/api_...')
#7 /home/xxx/xxx.com/app/code/core/Mage/Core/Controller/Varien/Action.php(419): JetRails_Cloudflare_Controller_Getter->indexAction()
#8 /home/xxx/xxx.com/app/code/core/Mage/Core/Controller/Varien/Router/Standard.php(254): Mage_Core_Controller_Varien_Action->dispatch('index')
#9 /home/xxx/xxx.com/app/code/core/Mage/Core/Controller/Varien/Front.php(176): Mage_Core_Controller_Varien_Router_Standard->match(Object(Mage_Core_Controller_Request_Http))
#10 /home/xxx/xxx.com/app/code/core/Mage/Core/Model/App.php(370): Mage_Core_Controller_Varien_Front->dispatch()
#11 /home/xxx/xxx.com/app/Mage.php(682): Mage_Core_Model_App->run(Array)
#12 /home/xxx/xxx.com/index.php(88): Mage::run('', 'store')
#13 {main}</pre>

[null93]

Great! Thanks for sharing, I will take care of this soon and update you here.

[null93]

I went ahead and renamed the methods in the models so there would be no more notice errors. I released v1.2.6 and it is available to download here: https://github.com/jetrails/magento-cloudflare/releases/tag/1.2.6.

Thanks again for bringing this up! Please re-open issue if problem still persists.

[lfolco]

Thank you!