fix: config silently ignored in projects

[ibuibu]

Summary

Fix #9761

PROBLEM

In the validation of config, when properties that does not exist in projects type (e.g. testSequenser, expand, etc.) is set, a warning is not displayed.

CAUSE

Although the types of projects and global properties are different, they are checked in the same way.

SOLUTION

When normalizing, determine whether the property is a projects property or a global property, and if it is a projects property, use a special object.

Test plan

Test config is below.

module.exports = {
  testSequencer: "./jestSequencer.js",
  projects: [
    {
      testSequencer: "./jestSequencer.js",
      expand: true,
    },
  ],
};

Before the change, no warning is displayed, but after the change, warnings are displayed as shown below.

It has also been confirmed that the same normal operation is achieved when an array containing is specified as a string, as shown below.

module.exports = {
  testSequencer: "./jestSequencer.js",
  projects: ["<rootDir>", "project_b"],
};

[SimenB]

nice! could you add some tests and a changelog entry?

[ibuibu]

ok. thanks for reviewing.

[facebook-github-bot]

Hi @ibuibu!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[SimenB]

Thanks @ibuibu!

[SimenB]

https://github.com/facebook/jest/releases/tag/v29.3.0

[SimenB]

@ibuibu found a bug with this one.

In this very repo, there is.

At work there's also

[mhenniges]

The preset issue is occurring for me to. If I remove ”preset”: “ts-jest/presets/default-esm” from the package-specific configs, test no longer work with the error "Top-level ‘await’ expressions are only allowed when the ‘module’ option is set to ‘es2022’, ‘esnext’, ‘system’, ‘node16’, or ‘nodenext’, and the ‘target’ option is set to ‘es2017’ or higher."

[SimenB]

Yeah, preset is definitely allowed. Not sure about watch-plugins, but I imagine so

[ibuibu]

@SimenB
Thanks for fixing 🙏

[SimenB]

Issue for other fields: #13576. As mentioned there, I'll need to revisit tomorrow.

I isolation, this PR is correct, but it seems our types for ProjectConfig are incomplete, or at least do not behave the same as normalize outputs.

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.