ts-migration/index

[G-Rath]

chore(index): convert to typescript.

Might as well break this out too 😂

[SimenB]

see inline comment

[SimenB]

This fails locally due to #371 not being merged. Can land after that's done 🙂

[G-Rath]

haha yeah I saw that - I'm doing that right now.

btw do you want parse in this?

[SimenB]

Ah yeah, parse looks like a nice improvement over basename

[G-Rath]

.filter(rule => !excludedFiles.includes(rule))

Woops... 😅

I was about to amend the "bad" commit message, but now that you've pushed, I'll leave it to you if that's ok.

Once this has been merged would you mind rebasing #363 for me? I did it locally, but something weird happened and it decided to not apply the change to snapshot-processor.test.ts so it was using the old const { snapshotProcessor } import 😬

I can do it if you're not got the time :)

[G-Rath]

This is actually surprisingly "slow" vs using an assignment, b/c everytime you're creating a new object & copying all the keys.

It's by far not a big deal, and even less so since we're doing it the once (I hope? I assume the way eslint runs it typically reuses the same node process), but it's an interesting little fact.

(That might have changed in later versions of node - iirc I last tested this on node8)

[SimenB]

doing it once during require, yeah - probably not even measurable except in micro benchmarks. Nothing compared to the FS operations in the same file 🙂

[SimenB]

and yeah, object spread has gotten way quicker (although it's currently transpiled down by babel until we drop node 6)

https://twitter.com/bmeurer/status/1015105293301280768?lang=en

[SimenB]

Rebased #363 now. I think I did it right 😛

[SimenB]

🎉 This PR is included in version 22.15.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[G-Rath]

@SimenB

SyntaxError: /c/Users/G-Rath/workspace/projects-personal/eslint-plugin-jest/src/index.ts: export = is not supported by @babel/plugin-transform-typescript
Please consider using export <value>;.
31 |
32 | // eslint-disable-next-line import/no-commonjs
> 33 | export = {

That's the syntax for modules.export 😭

[SimenB]

I wrote a custom babel plugin for it in jest: https://github.com/facebook/jest/blob/master/scripts/babel-plugin-jest-replace-ts-export-assignment.js

[G-Rath]

oohhhohhh exciting!

My company does investment time (but are not thoughtbot 😉) every Friday (which is tomorrow), so I'll explore that plugin, and look about adding it at some point :D

[SimenB]

Feel free to rip it out, publish it, and send a PR to jest migrating to using the published version 🙂

[G-Rath]

Sure thing :D