ts-migration/prefer-strict-equals #329
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a fair bit of mental headaches and a couple of rewrites, it's finally here - the beginning of converting the
expect<x>methods!Rather than try & re-implement the entire behaviour of utility functions in one go, I've opted to pretty much chucking them straight out, and implementing new guards as required by each rule.
This should result in a much smoother conversation process, as well as a more formal & official definition of parts of the AST tree by end. In particular, it'll make it much easier to test the boundaries of rules, as it's very hard to test changes to the conditional checks when the majority of the rules that use them are still in JS.
I've also decided to completely ignore
LiteralvsIdentifier, opting for now to just sayLiterals are not supported.The rational is that it's faster, as once we have all the rules converted, we just need to change the types in two interfaces to be
TSESTree.Identifier | TSESTree.Literal, and TypeScript will tell us where the implementation needs to be adjusted to support said change.