ts-migration/consistent-test-it

[G-Rath]

No description provided.

[SimenB]

can we use the enum instead of string?

[SimenB]

new, but seeing as tests pass I guess it doesn't matter.

[G-Rath]

It's required by typescript - getNodeName could always return null, but not always checked:

export const getNodeName = node => {
  function joinNames(a, b) {
    return a && b ? `${a}.${b}` : null;
  }

  switch (node && node.type) {
    case 'Identifier':
      return node.name;
    case 'MemberExpression':
      return joinNames(getNodeName(node.object), getNodeName(node.property));
  }

  return null;
};

Ah, the joys of complex ASTs 😂

[G-Rath]

seeing as tests pass I guess it doesn't matter.

I believe this is b/c of the isDescribe - the conditions for which getNodeName would return null are mutually exclusive w/ isDescribe, which is why this has never been a problem.

I mean, that branch must be being hit b/c coverage isn't complaining, so it can happen.

[G-Rath]

Just so it's written down somewhere, this is the code that can be used to make getNodeName to return null:

[1,2,3].forEach(() => { test("foo") })

It's b/c [1,2,3] is an ArrayExpression, which causes getNodeName to bail out.

I needed to know how to do this to implement a test for another rule to get coverage other the line :)

[SimenB]

do we need as const on the schema?

[SimenB]

might not need the type info here then. Maybe not though, not sure how enum in schema works

[G-Rath]

Not as far as I'm aware - the schema is json schema, so it's not actually used by TS (it'd be cool if it was, but it's far too complex)