ts-migration/no-if #324
ts-migration/no-if #324
Conversation
src/rules/no-if.ts
Outdated
| 'test.skip', | ||
| ]); | ||
|
|
||
| const isTestArrowFunction = (node: TSESTree.Node) => |
There was a problem hiding this comment.
This function is only used by ArrowFunctionExpression, so you can do node: TSESTree.ArrowFunctionExpression and ditch the undefined and node.type checks
There was a problem hiding this comment.
Actually apparently I can leave it as TSESTree.Node, but yeah much better!
There was a problem hiding this comment.
no need to widen the type when we don't need it 🙂
There was a problem hiding this comment.
Given the functions name (isTestArrowFunction), I think it should: either it should test that the type is ArrowFunctionExpression, or it should test if a given ArrowFunctionExpression is a "test" arrow function.
| } from '@typescript-eslint/experimental-utils'; | ||
|
|
||
| const isTestArrowFunction = node => | ||
| const testCaseNames = new Set<string | null>([ |
There was a problem hiding this comment.
Yeah that's just b/c of how the typings work in relation to #has.
Basically, it's defined like this:
interface Set<T> {
has(item: T): boolean;
}
That means if T is just string, you can't do has checks against things like null, which is a possible return of getNodeName :)
Originally I had getNodeName(/* ... */) || '', but since that's a runtime solution, it's expected to be tested for by branch coverage 😂
src/rules/no-if.ts
Outdated
| const stack: Array<boolean> = []; | ||
|
|
||
| function validate(node) { | ||
| function validate(node: TSESTree.Node) { |
There was a problem hiding this comment.
| function validate(node: TSESTree.Node) { | |
| function validate(node: TSESTree.ConditionalExpression | TSESTree.IfStatement) { |
2 participants
No description provided.