ts-migration/no-hooks #322
Conversation
fo sho |
| return hashMap; | ||
| }, Object.create(null)); | ||
|
|
||
| const isWhitelisted = (node: { callee: { name: string } }) => |
There was a problem hiding this comment.
| const isWhitelisted = (node: { callee: { name: string } }) => | |
| const isWhitelisted = (node: JestFunctionCallExpressionWithIdentifierCallee<HookName>) => |
There was a problem hiding this comment.
Could we possibly do export type JestHookFunction = JestFunctionCallExpressionWithIdentifierCallee<HookName> or something? 🙂 The name is so long... 😛
There was a problem hiding this comment.
Could we possibly do...
fo sho
The name is so long... 😛
Yeah, it is - I might do a clean up PR soon, and rename them to something like Fn to make them a touch shorter.
Sadly, that's just pretty much what always happens when working w/ AST nodes - there's so much contextual type information that you end up w/ really very verbose but long type names 😂
There was a problem hiding this comment.
Yeah, we can go through after everything is migrated. I bet we'll see some patterns or something we can abstract out to make it a bit more readable at that point
2 participants
It might be best to rebase
reapply-tsonmaster, then rebase this PR 😬@SimenB can I leave that to you?