ts-migration/no-focused-tests #314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimenB
reviewed
Jul 19, 2019
SimenB
approved these changes
Jul 20, 2019
SimenB
requested changes
Jul 20, 2019
| AST_NODE_TYPES, | ||
| TSESTree, | ||
| } from '@typescript-eslint/experimental-utils'; | ||
| import { DescribeAlias, TestCaseName, createRule } from './tsUtils'; |
Member
There was a problem hiding this comment.
You forgot to export these new ones
Collaborator
Author
There was a problem hiding this comment.
O.o I feel like I need to commit sudoku - how did I miss that...?
Collaborator
Author
There was a problem hiding this comment.
Actually no it just needs to be merged w/ reapply-ts :)
Member
There was a problem hiding this comment.
ah, you've cherry-picked. Makes sense 🙂
Collaborator
Author
There was a problem hiding this comment.
Yeah it got lost in the shuffle. The whole guard thing + timezones threw me for a loop 😂
SimenB
approved these changes
Jul 20, 2019
SimenB
pushed a commit
that referenced
this pull request
Jul 20, 2019
SimenB
pushed a commit
that referenced
this pull request
Jul 21, 2019
SimenB
pushed a commit
that referenced
this pull request
Jul 21, 2019
SimenB
pushed a commit
that referenced
this pull request
Jul 22, 2019
SimenB
pushed a commit
that referenced
this pull request
Jul 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The meta information should be checked to make sure it's correct :)