Skip to content

Conversation

@G-Rath
Copy link
Collaborator

@G-Rath G-Rath commented Jul 18, 2019

This is an updated version of my original ts-migration/no-mocks-import branch.

I bypassed the githooks while committing these, b/c it was having issues:

husky > pre-commit (node v10.15.3)
Stashing changes... [started]
Stashing changes... [skipped]
→ No partially staged files found...
Running linters... [started]
Running tasks for *.{js,ts} [started]
Running tasks for *.{md,json} [started]
Running tasks for *.{md,json} [skipped]
→ No staged files match *.{md,json}
eslint --fix [started]
eslint --fix [completed]
git add [started]
git add [completed]
Running tasks for *.{js,ts} [completed]
Running linters... [completed]
husky > commit-msg (node v10.15.3)
C:\Users\G-Rath\workspace\projects-personal\eslint-plugin-jest\node_modules\@commitlint\cli\lib\cli.js:96
		throw err;
		^
Error: ENOENT: no such file or directory, open 'C:\Users\G-Rath\workspace\projects-personal\eslint-plugin-jest\$HUSKY_GIT_PARAMS'
husky > commit-msg hook failed (add --no-verify to bypass)

It might be related to husky just releasing a new version?

@G-Rath G-Rath mentioned this pull request Jul 18, 2019
35 tasks
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@SimenB SimenB merged commit 3c2cbcd into jest-community:reapply-ts Jul 18, 2019
@G-Rath G-Rath deleted the ts-migration/no-mocks-import-2 branch July 18, 2019 22:17
@G-Rath
Copy link
Collaborator Author

G-Rath commented Jul 18, 2019

No problem! So does this mean we've got the green light to start converting?

I've currently got my eye on no-test-prefixes - I've also made #310 since those are used by most of the hooks, and dead easy to port over :)

@SimenB
Copy link
Member

SimenB commented Jul 18, 2019

For sure, just start picking rules! 🙂 The only reason it's not in master is that I'm waiting for a non-canary release of the TS utils

SimenB pushed a commit that referenced this pull request Jul 20, 2019
SimenB pushed a commit that referenced this pull request Jul 20, 2019
SimenB pushed a commit that referenced this pull request Jul 21, 2019
SimenB pushed a commit that referenced this pull request Jul 22, 2019
SimenB pushed a commit that referenced this pull request Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants