chore: port lowercase-name to TypeScript #258
Conversation
|
|
||
| const { RuleTester } = require('eslint'); | ||
| const rule = require('../lowercase-name'); | ||
| const RuleTester: TSESLint.RuleTester = ESLintRuleTester as any; |
There was a problem hiding this comment.
| const RuleTester: TSESLint.RuleTester = ESLintRuleTester as any; | ||
|
|
||
| const ruleTester = new RuleTester({ | ||
| parser: '@typescript-eslint/parser', |
There was a problem hiding this comment.
I find it odd they require this - even if the rule is written in TS, it might not necessarily only run with that parser. Might be needed for all I know 🤷♂
|
@jeysal thanks for the review! I reimplemented this now with what I think is a better approach, with my own internal types that are more specific, and type guarding for them. I like this approach, could you take a look? |
|
Typings look nice! 😅 (hell yeah, statically verify everything 💪) |
|
Thanks @jeysal! |
SimenB
changed the title
|
🎉 This PR is included in version 22.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
For #256. Includes #257, so just review the second commit.
The diff looks bigger than it is since I had to rewrite all the helpers to include type guards. The implementation of the rule itself is identical.
I can extract the changes to
indexetc to a separate PR if wanted so this is focused on just the rule porting@jeysal any help here would be greatly appreciated 🙂