-
Notifications
You must be signed in to change notification settings - Fork 243
chore: precompile with babel #257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,2 @@ | ||
| coverage/ | ||
| lib/ |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,3 @@ | ||
| node_modules/ | ||
| coverage/ | ||
| lib/ |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| 'use strict'; | ||
|
|
||
| module.exports = { | ||
| presets: [['@babel/preset-env', { targets: { node: 6 } }]], | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why not Node 8 and next release major?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No need to make a breaking change, exactly 0 benefit
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. whenever we wanna make a new major we can drop 6 though, no reason to keep it at that point |
||
| }; | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16,24 +16,31 @@ | |
| }, | ||
| "files": [ | ||
| "docs/", | ||
| "rules/", | ||
| "processors/", | ||
| "index.js" | ||
| "src/", | ||
| "lib/" | ||
| ], | ||
| "main": "lib/", | ||
| "engines": { | ||
| "node": ">=6" | ||
| }, | ||
| "peerDependencies": { | ||
| "eslint": ">=5" | ||
| }, | ||
| "scripts": { | ||
| "postinstall": "yarn build", | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is auto-build after install helpful in this case?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Lint will fail since we run with our own rules. And jest runs lint, so it'd fail
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Okay, didn't consider that 👍
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @SimenB We can't assume that the user has I think we should revert it for now.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe the intention was |
||
| "lint": "eslint . --ignore-pattern '!.eslintrc.js'", | ||
| "prettylint": "prettylint docs/**/*.md README.md package.json", | ||
| "test": "jest" | ||
| "prepublishOnly": "yarn build", | ||
| "test": "jest", | ||
| "build": "babel src --out-dir lib" | ||
| }, | ||
| "devDependencies": { | ||
| "@babel/cli": "^7.4.4", | ||
| "@babel/core": "^7.4.4", | ||
| "@babel/preset-env": "^7.4.4", | ||
| "@commitlint/cli": "^7.0.0", | ||
| "@commitlint/config-conventional": "^7.0.1", | ||
| "babel-jest": "^24.8.0", | ||
| "eslint": "^5.1.0", | ||
| "eslint-config-prettier": "^4.1.0", | ||
| "eslint-plugin-eslint-plugin": "^2.0.0", | ||
|
|
@@ -49,7 +56,7 @@ | |
| "prettier": { | ||
| "proseWrap": "always", | ||
| "singleQuote": true, | ||
| "trailingComma": "es5" | ||
| "trailingComma": "all" | ||
| }, | ||
| "lint-staged": { | ||
| "*.js": [ | ||
|
|
@@ -73,13 +80,19 @@ | |
| "projects": [ | ||
| { | ||
| "displayName": "test", | ||
| "testEnvironment": "node" | ||
| "testEnvironment": "node", | ||
| "testPathIgnorePatterns": [ | ||
| "<rootDir>/lib/.*" | ||
| ] | ||
| }, | ||
| { | ||
| "displayName": "lint", | ||
| "runner": "jest-runner-eslint", | ||
| "testMatch": [ | ||
| "<rootDir>/**/*.js" | ||
| ], | ||
| "testPathIgnorePatterns": [ | ||
| "<rootDir>/lib/.*" | ||
| ] | ||
| } | ||
| ] | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
babel deals with syntax