Add failing test for no-mocks-import dynamic requires
#249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adeira-github-bot
pushed a commit
to kiwicom/eslint-config-kiwicom
that referenced
this pull request
Apr 24, 2019
The new eslint rule `jest/no-mocks-import` is disabled for now because of some issue with dynamic imports. See: jest-community/eslint-plugin-jest#249 kiwicom-source-id: 7b3cacb71cb79871f9caf2b3f3677500b0111796
SimenB
pushed a commit
that referenced
this pull request
Apr 25, 2019
Fixes #249 Co-authored-by: Martin Zlámal <[email protected]>
|
🎉 This issue has been resolved in version 22.5.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I tried the new
no-mocks-importrule (#246) but it's failing on dynamicimportsrequires. I am adding at least this failing test since I am not sure how to fix it properly. Thank you for checking it! :)