Prevent arguments object creation if 'arguments' function argument is present #4849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rerobika
added
bug
rerobika
force-pushed
the
fix_arguments_object_creation
branch
2 times, most recently
from
d8d2ec7 to
fbb1d4c
Compare
rerobika
changed the title
… present This patch fixes jerryscript-project#4847. JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik [email protected]
rerobika
force-pushed
the
fix_arguments_object_creation
branch
from
fbb1d4c to
3bb042b
Compare
robertsipka
approved these changes
Dec 7, 2021
dbatyai
approved these changes
Dec 7, 2021
zherczeg
reviewed
Dec 7, 2021
| { | ||
| /* 'arguments' function argument existence should prevent the arguments object construction */ | ||
| new_literal_pool_p->status_flags = | ||
| (uint16_t) (new_literal_pool_p->status_flags |
| if (has_arguments) | ||
| { | ||
| /* Force the lexically stored arguments object creation */ | ||
| literal_pool_p->status_flags |= (SCANNER_LITERAL_POOL_ARGUMENTS_IN_ARGS | SCANNER_LITERAL_POOL_NO_ARGUMENTS); |
There was a problem hiding this comment.
I would put the argument checking as a for loop here since the while (true) loop might also exit. This case is rare, so an extra loop should not cost much.
|
Note: still crashes |
rerobika
pushed a commit
to rerobika/jerryscript
that referenced
this pull request
Dec 8, 2021
This patch is the followup of jerryscript-project#4849. JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik [email protected]
rerobika
pushed a commit
to rerobika/jerryscript
that referenced
this pull request
Dec 8, 2021
This patch is the followup of jerryscript-project#4849. JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik [email protected]
ossy-szeged
pushed a commit
that referenced
this pull request
Dec 15, 2021
This patch is the followup of #4849. JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik [email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes #4847.
JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik [email protected]