Skip to content

Fix implicit 'double' conversion reported by Clang #4296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 19, 2020
Merged

Fix implicit 'double' conversion reported by Clang #4296

merged 1 commit into from
Oct 19, 2020

Conversation

@kaadam
Copy link
Contributor

@kaadam kaadam commented Oct 19, 2020

JerryScript-DCO-1.0-Signed-off-by: Adam Kallai [email protected]

@kaadam
Fix implicit 'double' conversion reported by Clang
6523701 
JerryScript-DCO-1.0-Signed-off-by: Adam Kallai [email protected]
rerobika
rerobika approved these changes Oct 19, 2020
View reviewed changes
Copy link
Member

@rerobika rerobika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kaadam
Copy link
Contributor Author

kaadam commented Oct 19, 2020

Hi Folks,
It remained one conversion error reported by Clang, this CL aims to fix that.
A snippet of the error:
/home/kadam/jerryscript/jerry-core/ecma/builtin-objects/ecma-builtin-array-prototype.c:1309:7: error: implicit conversion from 'ecma_length_t' (aka 'unsigned long') to 'double' may lose precision [-Werror
,-Wimplicit-int-float-conversion]
if (new_length > ECMA_NUMBER_MAX_SAFE_INTEGER)
^~~~~~~~~~
Could anyone take a look at that?

@ossy-szeged
Copy link
Contributor

ossy-szeged commented Oct 19, 2020

LGTM (informal)

zherczeg
zherczeg approved these changes Oct 19, 2020
View reviewed changes
Copy link
Member

@zherczeg zherczeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zherczeg zherczeg merged commit 23e9e77 into jerryscript-project:master Oct 19, 2020
@akosthekiss akosthekiss mentioned this pull request Jan 8, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zherczeg zherczeg zherczeg approved these changes

@rerobika rerobika rerobika approved these changes

Assignees

No one assigned

Labels

hacktoberfest-accepted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kaadam @ossy-szeged @zherczeg @rerobika