Skip to content

Conversation

@dbatyai
Copy link
Member

@dbatyai dbatyai commented Oct 6, 2020

Replacer functions might release the original bytecode, keeping an extra reference will make sure that the bytecode stays alive.

@dbatyai dbatyai added bug Undesired behaviour ecma builtins Related to ECMA built-in routines labels Oct 6, 2020
@dbatyai
Copy link
Member Author

dbatyai commented Oct 6, 2020

This issue is already covered by the test case from #3070, however it depends on garbage collection.

Copy link
Member

@rerobika rerobika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@zherczeg zherczeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zherczeg zherczeg merged commit 5b9a6de into jerryscript-project:master Oct 8, 2020
@dbatyai dbatyai deleted the replace_bytecode_ref branch October 26, 2021 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Undesired behaviour ecma builtins Related to ECMA built-in routines hacktoberfest-accepted

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants