Skip to content

Fix a typo in case of single thread/process execution in test262 harness #4223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 28, 2020
Merged

Fix a typo in case of single thread/process execution in test262 harness #4223

merged 1 commit into from
Sep 28, 2020

Conversation

@galpeter
Copy link
Contributor

@galpeter galpeter commented Sep 23, 2020 •
edited
Loading

No description provided.

@galpeter galpeter added test Related to testing ES2015 Related to ES2015 features ES.next Related to ES2015+ features labels Sep 23, 2020
@ossy-szeged
Copy link
Contributor

ossy-szeged commented Sep 24, 2020

I think we won't need it after 3b7409f . But let's wait a little bit before closing this PR.
Otherwise the typo fix in run function should be landed.

@galpeter galpeter changed the title Force CI system to use a single thread/process for test262 Fix a typo in case of single thread/process execution in test262 harness Sep 25, 2020
@galpeter
Copy link
Contributor Author

galpeter commented Sep 25, 2020

Updated PR to only have the typo fix.

@ossy-szeged
Copy link
Contributor

ossy-szeged commented Sep 25, 2020

LGTM (informal)

dbatyai
dbatyai approved these changes Sep 25, 2020
View reviewed changes
Copy link
Member

@dbatyai dbatyai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rerobika
rerobika approved these changes Sep 25, 2020
View reviewed changes
Copy link
Member

@rerobika rerobika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dbatyai dbatyai merged commit 0ffe166 into jerryscript-project:master Sep 28, 2020
@akosthekiss akosthekiss mentioned this pull request Jan 8, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dbatyai dbatyai dbatyai approved these changes

@rerobika rerobika rerobika approved these changes

@ossy-szeged ossy-szeged Awaiting requested review from ossy-szeged

Assignees

No one assigned

Labels

ES.next Related to ES2015+ features ES2015 Related to ES2015 features test Related to testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@galpeter @ossy-szeged @dbatyai @rerobika