Implement TrimStart TrimEnd and aliases #4102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rerobika
requested changes
Aug 4, 2020
jerry-core/ecma/builtin-objects/ecma-builtin-string-prototype.inc.h
Outdated
Show resolved
Hide resolved
Achie72
force-pushed
the
trimFunctions
branch
8 times, most recently
from
7c925fd to
c183a90
Compare
dbatyai
requested changes
Aug 6, 2020
jerry-core/ecma/base/ecma-helpers.h
Outdated
| ECMA_TRIM_STRING_START = (1u << 0), /**< Trim only from the start */ | ||
| ECMA_TRIM_STRING_END = (1u << 1), /**< Trim only from the end */ | ||
| ECMA_TRIM_STRING_STARTEND = (1u << 2), /**< Trim from both start and end */ | ||
| } ecma_string_trim_flags_t; |
Member
There was a problem hiding this comment.
No need for these, just call ecma_string_trim_front/ecma_string_trim_back where necessary, and change ecma_string_trim_helper to call both, and be always inline.
Achie72
force-pushed
the
trimFunctions
branch
5 times, most recently
from
7706e95 to
bb4cf69
Compare
dbatyai
requested changes
Aug 12, 2020
jerry-core/ecma/builtin-objects/ecma-builtin-string-prototype.inc.h
Outdated
Show resolved
Hide resolved
Achie72
force-pushed
the
trimFunctions
branch
2 times, most recently
from
0765ed3 to
6e4415b
Compare
rerobika
requested changes
Aug 17, 2020
dbatyai
requested changes
Aug 24, 2020
ossy-szeged
reviewed
Aug 24, 2020
Comment on lines
2487
to
2488
| * - ecma_builtin_global_object_parse_int | ||
| * - ecma_builtin_global_object_parse_float |
Contributor
There was a problem hiding this comment.
parseInt and parseFloat should only use trimStart by spec
Member
Author
There was a problem hiding this comment.
This is a nice catch i did not look into. Although roughly looking at them this should not alter as the code checks for digits when iterating and in the end, the ecma_utf8_string_to_number call the whole trim in itself as well. I'm looking into our test suites to check for fails if i modify this.
Based on: https://tc39.es/ecma262/#sec-string.prototype.trim JerryScript-DCO-1.0-Signed-off-by: Bela Toth [email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on: https://tc39.es/ecma262/#sec-string.prototype.trim
JerryScript-DCO-1.0-Signed-off-by: Bela Toth [email protected]