Fix build with disabled ES2015 module system #4084
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galpeter
force-pushed
the
fix_build_nomodule
branch
from
b872133 to
29bde04
Compare
Contributor
|
LGTM (informal) |
dbatyai
reviewed
Jul 30, 2020
| #if ENABLED (JERRY_MODULE_SYSTEM) | ||
| parser_compiled_code_set_function_name (context_p, compiled_code_p, function_name_index, 0); | ||
| #endif /* ENABLED (JERRY_ESNEXT) */ | ||
| #endif /* ENABLED (JERRY_MODULE_SYSTEM) */ |
Member
There was a problem hiding this comment.
Are you sure this should be module guarded? This seems more related to function names than modules.
Contributor
Author
There was a problem hiding this comment.
True, with this the function will not have a name in case of disabled module system. Will update.
With a disabled ES2015 module system the build fails as an enum value is incorrectly guarded and used. JerryScript-DCO-1.0-Signed-off-by: Peter Gal [email protected]
galpeter
force-pushed
the
fix_build_nomodule
branch
from
29bde04 to
87b1b9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With a disabled ES2015 module system the build fails as an enum value
is incorrectly guarded and used.